Skip to content

correct model save name in example fp8 dynamic#2475

Merged
dsikka merged 2 commits intomainfrom
HDCharles-patch-6
Mar 17, 2026
Merged

correct model save name in example fp8 dynamic#2475
dsikka merged 2 commits intomainfrom
HDCharles-patch-6

Conversation

@HDCharles
Copy link
Copy Markdown
Collaborator

SUMMARY:
this was misleading as in #2330

Signed-off-by: HDCharles <39544797+HDCharles@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor but important correction in an example script. It updates the naming convention for saved models to ensure the directory name precisely matches the quantization technique (FP8 dynamic) used in the example. This change enhances the accuracy and usability of the example for users, preventing potential confusion regarding the saved model's configuration.

Highlights

  • Example Script Correction: Corrected the model save directory name in the fp8_dynamic_llama_example.py script to accurately reflect the FP8 dynamic quantization method, improving clarity and consistency.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • examples/awq/fp8_dynamic_llama_example.py
    • Updated the SAVE_DIR variable to reflect the correct FP8 dynamic quantization method.
Activity
  • No specific activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@HDCharles HDCharles changed the title correct model save name in example correct model save name in example fp8 dynamic Mar 16, 2026
@mergify mergify bot added the documentation Improvements or additions to documentation label Mar 16, 2026
@HDCharles HDCharles added the ready When a PR is ready for review label Mar 16, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects a misleading save directory name in the fp8_dynamic_llama_example.py example, aligning it with the FP8_DYNAMIC quantization scheme used. The change is correct and improves clarity. I've also added a suggestion to include this example in the test suite to improve maintainability and prevent future regressions.

@dsikka dsikka merged commit 304f7b9 into main Mar 17, 2026
10 of 12 checks passed
@dsikka dsikka deleted the HDCharles-patch-6 branch March 17, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready When a PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants