Conversation
Signed-off-by: yiliu30 <yi4.liu@intel.com>
Signed-off-by: yiliu30 <yi4.liu@intel.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces experimental support for MXFP8 quantization within LLM Compressor, enabling users to quantize both weights and activations using this scheme. It includes a new example script demonstrating how to apply MXFP8 quantization to a Qwen3-8B model and updates the project's Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
There was a problem hiding this comment.
Code Review
This pull request introduces experimental MXFP8 quantization support, updating the README.md to reflect this new feature and providing a concrete Python example script. The example script demonstrates how to apply MXFP8 quantization to a Qwen3-8B model using llmcompressor and then perform a sample generation. The changes are well-aligned with the PR's objective.
Signed-off-by: yiliu30 <yi4.liu@intel.com>
Signed-off-by: yiliu30 <yi4.liu@intel.com>
Signed-off-by: yiliu30 <yi4.liu@intel.com>
brian-dellabetta
left a comment
There was a problem hiding this comment.
Thank you @yiliu30 !
SUMMARY: As the title. Depends on vllm-project/compressed-tensors#630 TEST PLAN: ```bash ========== SAMPLE GENERATION ============== The attention mask is not set and cannot be inferred from input because pad token is same as eos token. As a consequence, you may observe unexpected behavior. Please pass your input's `attention_mask` to obtain reliable results. Hello my name is James and I am 20 years old. I am an aspiring musician and I am currently studying ========================================== ``` Checkpoints: - https://huggingface.co/INC4AI/Qwen3-8B-MXFP8A16-LLMC-TEST-ONLY - https://huggingface.co/INC4AI/Qwen3-8B-MXFP8-LLMC-TEST-ONLY cc @hshen14 @thuang6 --------- Signed-off-by: yiliu30 <yi4.liu@intel.com> Co-authored-by: Dipika Sikka <dipikasikka1@gmail.com> Signed-off-by: David Zheng <dqzheng1996@gmail.com>
SUMMARY: As the title. Depends on vllm-project/compressed-tensors#630 TEST PLAN: ```bash ========== SAMPLE GENERATION ============== The attention mask is not set and cannot be inferred from input because pad token is same as eos token. As a consequence, you may observe unexpected behavior. Please pass your input's `attention_mask` to obtain reliable results. Hello my name is James and I am 20 years old. I am an aspiring musician and I am currently studying ========================================== ``` Checkpoints: - https://huggingface.co/INC4AI/Qwen3-8B-MXFP8A16-LLMC-TEST-ONLY - https://huggingface.co/INC4AI/Qwen3-8B-MXFP8-LLMC-TEST-ONLY cc @hshen14 @thuang6 --------- Signed-off-by: yiliu30 <yi4.liu@intel.com> Co-authored-by: Dipika Sikka <dipikasikka1@gmail.com> Signed-off-by: David Zheng <dqzheng1996@gmail.com>
SUMMARY:
As the title.
Depends on vllm-project/compressed-tensors#630
TEST PLAN:
Checkpoints:
cc @hshen14 @thuang6