Skip to content

Add MXFP8 Example#2487

Merged
dsikka merged 6 commits intovllm-project:mainfrom
yiliu30:mxfp8-example
Mar 20, 2026
Merged

Add MXFP8 Example#2487
dsikka merged 6 commits intovllm-project:mainfrom
yiliu30:mxfp8-example

Conversation

@yiliu30
Copy link
Contributor

@yiliu30 yiliu30 commented Mar 19, 2026

SUMMARY:
As the title.
Depends on vllm-project/compressed-tensors#630

TEST PLAN:

========== SAMPLE GENERATION ==============
The attention mask is not set and cannot be inferred from input because pad token is same as eos token. As a consequence, you may observe unexpected behavior. Please pass your input's `attention_mask` to obtain reliable results.
Hello my name is James and I am 20 years old. I am an aspiring musician and I am currently studying
==========================================

Checkpoints:

cc @hshen14 @thuang6

yiliu30 added 2 commits March 19, 2026 07:54
Signed-off-by: yiliu30 <yi4.liu@intel.com>
Signed-off-by: yiliu30 <yi4.liu@intel.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces experimental support for MXFP8 quantization within LLM Compressor, enabling users to quantize both weights and activations using this scheme. It includes a new example script demonstrating how to apply MXFP8 quantization to a Qwen3-8B model and updates the project's README.md to document this new capability and provide a direct link to the example.

Highlights

  • MXFP8 Microscale Support: LLM Compressor now experimentally supports MXFP8 quantization for both weights and activations via Post-Training Quantization (PTQ), including a new example script.
  • Documentation Update: The README.md has been updated to reflect the new MXFP8 support and link to the corresponding example.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@mergify mergify bot added the documentation Improvements or additions to documentation label Mar 19, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces experimental MXFP8 quantization support, updating the README.md to reflect this new feature and providing a concrete Python example script. The example script demonstrates how to apply MXFP8 quantization to a Qwen3-8B model using llmcompressor and then perform a sample generation. The changes are well-aligned with the PR's objective.

dsikka and others added 4 commits March 19, 2026 17:44
Signed-off-by: yiliu30 <yi4.liu@intel.com>
Signed-off-by: yiliu30 <yi4.liu@intel.com>
Signed-off-by: yiliu30 <yi4.liu@intel.com>
@dsikka dsikka added the ready When a PR is ready for review label Mar 20, 2026
@dsikka dsikka enabled auto-merge (squash) March 20, 2026 14:55
Copy link
Collaborator

@brian-dellabetta brian-dellabetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yiliu30 !

@dsikka dsikka merged commit 026c917 into vllm-project:main Mar 20, 2026
15 of 16 checks passed
dzhengAP pushed a commit to dzhengAP/llm-compressor that referenced this pull request Mar 20, 2026
SUMMARY:
As the title.
Depends on vllm-project/compressed-tensors#630

TEST PLAN:
```bash
========== SAMPLE GENERATION ==============
The attention mask is not set and cannot be inferred from input because pad token is same as eos token. As a consequence, you may observe unexpected behavior. Please pass your input's `attention_mask` to obtain reliable results.
Hello my name is James and I am 20 years old. I am an aspiring musician and I am currently studying
==========================================
```

Checkpoints:
- https://huggingface.co/INC4AI/Qwen3-8B-MXFP8A16-LLMC-TEST-ONLY
- https://huggingface.co/INC4AI/Qwen3-8B-MXFP8-LLMC-TEST-ONLY

cc @hshen14 @thuang6

---------

Signed-off-by: yiliu30 <yi4.liu@intel.com>
Co-authored-by: Dipika Sikka <dipikasikka1@gmail.com>
Signed-off-by: David Zheng <dqzheng1996@gmail.com>
dzhengAP pushed a commit to dzhengAP/llm-compressor that referenced this pull request Mar 20, 2026
SUMMARY:
As the title.
Depends on vllm-project/compressed-tensors#630

TEST PLAN:
```bash
========== SAMPLE GENERATION ==============
The attention mask is not set and cannot be inferred from input because pad token is same as eos token. As a consequence, you may observe unexpected behavior. Please pass your input's `attention_mask` to obtain reliable results.
Hello my name is James and I am 20 years old. I am an aspiring musician and I am currently studying
==========================================
```

Checkpoints:
- https://huggingface.co/INC4AI/Qwen3-8B-MXFP8A16-LLMC-TEST-ONLY
- https://huggingface.co/INC4AI/Qwen3-8B-MXFP8-LLMC-TEST-ONLY

cc @hshen14 @thuang6

---------

Signed-off-by: yiliu30 <yi4.liu@intel.com>
Co-authored-by: Dipika Sikka <dipikasikka1@gmail.com>
Signed-off-by: David Zheng <dqzheng1996@gmail.com>
@dsikka dsikka mentioned this pull request Mar 24, 2026
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready When a PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants