Conversation
Summary: make mergify only auto label if there are ONLY examples/docs changes rather than whenever there are examples/docs changes Signed-off-by: HDCharles <charlesdavidhernandez@gmail.com>
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the accuracy of automated labeling within the repository by modifying the Mergify configuration. The change ensures that the 'auto doc' label is applied only to pull requests that are solely focused on documentation or example updates, preventing its application to PRs that also include changes to core functional code, testing suites, or CI/CD workflows. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Mergify configuration to refine the documentation label application by adding exclusions for src/, tests/, and .github/workflows/ directories. The review suggests that these exclusions are incomplete and could still lead to incorrect labeling for changes involving the Mergify configuration file itself, Makefile, or pyproject.toml, proposing a broader set of exclusions to prevent incorrect labeling.
.github/mergify.yml
Outdated
| - -files~=^src/ | ||
| - -files~=^tests/ | ||
| - -files~=^\.github/workflows/ |
There was a problem hiding this comment.
While these exclusions are a good start, the list is incomplete and could lead to incorrect labeling. For instance, changes to this mergify configuration file itself (.github/mergify.yml), the project's Makefile, or pyproject.toml would still get the documentation label if changed alongside a documentation file.
To make this rule more robust and align with the goal of labeling PRs with only documentation changes, I suggest broadening the exclusion for .github and adding other common project configuration files.
- -files~=^src/
- -files~=^tests/
- -files~=^\.github/
- -files~=^Makefile$
- -files~=^pyproject\.toml$
There was a problem hiding this comment.
I think this suggetion makes sense?
Updated Mergify configuration to include .github and specific files. Signed-off-by: HDCharles <39544797+HDCharles@users.noreply.github.com>
2 participants
Summary:
make mergify only auto label if there are ONLY
examples/docs changes rather than whenever there are examples/docs changes