feat: OpenAI batch API part 1 #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
Collaborator
|
Thanks @gaocegege . I will take a look at this PR soon! |
17 tasks
Collaborator
|
@gaocegege Hey, do you want this PR to be merged? Or you want to edit it a bit more? |
Collaborator
Author
|
I will address the comments first |
Collaborator
|
Thanks! Take your time please 👍 |
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
Collaborator
Author
|
Please take a look, thanks for your time 😄 |
ApostaC
previously approved these changes
Feb 7, 2025
Collaborator
ApostaC
left a comment
ApostaC
left a comment
There was a problem hiding this comment.
Just one minor comment. Other LGTM!
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
Collaborator
Author
|
Comments are addressed, please take a look. |
Collaborator
Author
|
Thanks. I will work on the part 2: the batch API. |
This was referenced Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the part 1 of #47
file.Storage has been introduced to abstract file operations, to support both OpenAI files and the uploads API. The user-id in the interface is defaulted to uid-default, which is kept for future extensibility.
I believe OpenAI uses a database, such as PostgreSQL, to store file metadata. For now, we are using simple file operations to handle this.
I’ve raised this PR to discuss whether this approach aligns with our requirements. Then will implement the batch API in part 2.