-
Notifications
You must be signed in to change notification settings - Fork 277
[Feat][Router] add ability to specify params to drop #650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
2384a1b
to
ce957f1
Compare
ce957f1
to
830d132
Compare
@YuhanLiu11 WDYT? |
@max-wittig This would be nice to have. Can you write some tests for this feature? |
@YuhanLiu11 I wanted to add some unittests, but the whole Is there any place where you could point me to where to add them? |
830d132
to
a39a86a
Compare
You can add the tests in https://github.com/vllm-project/production-stack/blob/main/tests/e2e/test-routing.py to send a request that specify params to drop and see if it did drop params from the request. |
request_body = json.dumps(request_json) | ||
update_content_length(request, request_body) | ||
|
||
# TODO (ApostaC): merge two awaits into one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please remove this comment? It is not relevant now.
a99afa2
to
828ce8c
Compare
Some LLMs don't support all params that clients could send. This MR gives the administrator the ability to filter those out Similar to https://docs.litellm.ai/docs/completion/drop_params Signed-off-by: Max Wittig <[email protected]>
828ce8c
to
8abf268
Compare
Signed-off-by: Max Wittig <[email protected]>
Some LLMs don't support all params that clients could send. This MR gives the administrator the ability to filter those out
Similar to https://docs.litellm.ai/docs/completion/drop_params
Tested using
-s
when doinggit commit
[Bugfix]
,[Feat]
, and[CI]
.Detailed Checklist (Click to Expand)
Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Feat]
for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).[Router]
for changes to thevllm_router
(e.g., routing algorithm, router observability, etc.).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
pre-commit
to format your code. SeeREADME.md
for installation.DCO and Signed-off-by
When contributing changes to this project, you must agree to the DCO. Commits must include a
Signed-off-by:
header which certifies agreement with the terms of the DCO.Using
-s
withgit commit
will automatically add this header.What to Expect for the Reviews
We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.