-
Notifications
You must be signed in to change notification settings - Fork 360
Fix incorrect import path in batch processor initialization #784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect import path in batch processor initialization #784
Conversation
Summary of ChangesHello @keyuchen21, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue where the batch API feature was completely unusable due to an incorrect module import path. By correcting a single line of code, the PR enables the batch API to function as intended, resolving a Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes a ModuleNotFoundError by updating an incorrect import path for LocalBatchProcessor. The change is direct and effectively resolves the bug that was crashing the router when the batch API was enabled. I have one suggestion to improve the maintainability of the code by using a relative import, since the imported module is within the same package.
Fixes vllm-project#766 The import statement for LocalBatchProcessor was using an incorrect path (vllm_router.batch.local_processor) that does not exist in the codebase. This caused a ModuleNotFoundError when users tried to enable the batch API with the --enable_batch_api flag. Changed the import to use the correct path: vllm_router.services.batch_service.local_processor This unblocks the batch API functionality which was previously unusable due to this import error. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Keyu Chen <54015474+keyuchen21@users.noreply.github.com>
7643a7f to
5916c21
Compare
Signed-off-by: Keyu Chen <54015474+keyuchen21@users.noreply.github.com>
ff7f504 to
344599b
Compare
|
@zerofishnoodles i think now it should be good to go now previous code: change to: |
zerofishnoodles
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the contribution!
Summary
Fixes #766
This PR corrects an incorrect import path that prevented the batch API feature from working.
Problem
When users tried to enable the batch API with the
--enable_batch_apiflag, the router would crash with aModuleNotFoundErrorbecause the import statement was referencing a non-existent module path.Incorrect import (line 9):
The directory
vllm_router/batch/does not exist in the codebase.Solution
Changed the import to use the correct path where
LocalBatchProcessoractually exists:Impact
--enable_batch_apiflagTesting
src/vllm_router/services/batch_service/local_processor.pyexists and contains theLocalBatchProcessorclass