-
Notifications
You must be signed in to change notification settings - Fork 34
[Doc] gpt-oss with function calling #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @aarnphm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the OpenAI/GPT-OSS.md documentation to include details on how to enable and utilize function calling capabilities with GPT-OSS models in vLLM. It provides specific command-line arguments for serving these models with function calling support and updates the feature compatibility matrix to reflect this new functionality.
Highlights
- Function Calling Documentation: Added a new section detailing how to enable function calling for GPT-OSS models.
- vLLM Serve Command Example: Provided a concrete vLLM serve command demonstrating the necessary flags (--tool-call-parser, --reasoning-parser, --enable-auto-tool-choice) for function calling.
- Compatibility Matrix Update: Updated the feature compatibility table to indicate that both Chat Completion API and Chat Completion API with Streaming now support function calling.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the documentation for gpt-oss
to include instructions for using function calling with the Chat Completion API. The changes are clear and well-placed. I've found a minor formatting inconsistency in the updated feature support table and provided a suggestion to fix it. Overall, this is a great addition to the documentation.
| Chat Completion API | ✅ | ✅ | ❌ | ❌ | ✅ | | ||
| Chat Completion API with Streaming | ✅ | ✅ | ❌ | ❌ | ✅ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some extra spaces after the ✅
emojis in these lines. For consistency with the rest of the table, it would be best to remove them.
| Chat Completion API | ✅ | ✅ | ❌ | ❌ | ✅ | | |
| Chat Completion API with Streaming | ✅ | ✅ | ❌ | ❌ | ✅ | | |
| Chat Completion API | ✅ | ✅ | ❌ | ❌ | ✅ | | |
| Chat Completion API with Streaming | ✅ | ✅ | ❌ | ❌ | ✅ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aarnphm Can you fix it?
Thanks! I'll merge it after vllm-project/vllm#22386 |
based from vllm-project/vllm#22386