Skip to content

Conversation

@yuluo-yx
Copy link
Contributor

@yuluo-yx yuluo-yx commented Sep 9, 2025

No description provided.

@yuluo-yx yuluo-yx requested a review from Xunzhuo as a code owner September 9, 2025 15:46
@netlify
Copy link

netlify bot commented Sep 9, 2025

Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit 596804f
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/68c18ee76aff640008936835
😎 Deploy Preview https://deploy-preview-103--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@yuluo-yx
Copy link
Contributor Author

yuluo-yx commented Sep 9, 2025

Go Report Card

@Xunzhuo ,hi this badge looks like some problems

@github-actions
Copy link

github-actions bot commented Sep 9, 2025

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 src

Owners: @rootfs, @Xunzhuo, @wangchen615
Files changed:

  • src/semantic-router/cmd/main.go
  • src/semantic-router/go.mod
  • src/semantic-router/pkg/api/server.go
  • src/semantic-router/pkg/api/server_test.go
  • src/semantic-router/pkg/cache/cache_test.go
  • src/semantic-router/pkg/config/config_test.go
  • src/semantic-router/pkg/config/parse_configfile_test.go
  • src/semantic-router/pkg/extproc/caching_test.go
  • src/semantic-router/pkg/extproc/edge_cases_test.go
  • src/semantic-router/pkg/extproc/endpoint_selection_test.go
  • src/semantic-router/pkg/extproc/reason_mode_config_test.go
  • src/semantic-router/pkg/extproc/reason_mode_selector.go
  • src/semantic-router/pkg/extproc/reason_mode_selector_test.go
  • src/semantic-router/pkg/extproc/reasoning_integration_test.go
  • src/semantic-router/pkg/extproc/request_handler.go
  • src/semantic-router/pkg/extproc/request_processing_test.go
  • src/semantic-router/pkg/extproc/response_handler.go
  • src/semantic-router/pkg/extproc/router.go
  • src/semantic-router/pkg/extproc/security_test.go
  • src/semantic-router/pkg/extproc/server.go
  • src/semantic-router/pkg/extproc/stream_handling_test.go
  • src/semantic-router/pkg/extproc/test_utils_test.go
  • src/semantic-router/pkg/metrics/metrics.go
  • src/semantic-router/pkg/metrics/metrics_test.go
  • src/semantic-router/pkg/services/classification.go
  • src/semantic-router/pkg/utils/classification/classifier.go
  • src/semantic-router/pkg/utils/classification/classifier_test.go
  • src/semantic-router/pkg/utils/http/response.go
  • src/semantic-router/pkg/utils/pii/policy.go

📁 website

Owners: @Xunzhuo
Files changed:

  • website/docs/intro.md

vLLM

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.

@rootfs
Copy link
Collaborator

rootfs commented Sep 10, 2025

go: finding module for package github.com/vllm-project/semantic-router/semantic-router/pkg/api
go: finding module for package github.com/vllm-project/semantic-router/semantic-router/pkg/observability
go: finding module for package github.com/vllm-project/semantic-router/semantic-router/pkg/metrics
go: finding module for package github.com/vllm-project/semantic-router/semantic-router/pkg/services
go: downloading github.com/vllm-project/semantic-router v0.0.0-20250909184249-fe0b5b58a091
go: finding module for package github.com/vllm-project/semantic-router/semantic-router/pkg/cache
go: finding module for package github.com/vllm-project/semantic-router/semantic-router/pkg/tools
go: finding module for package github.com/vllm-project/semantic-router/semantic-router/pkg/utils/classification
go: finding module for package github.com/vllm-project/semantic-router/semantic-router/pkg/utils/http
go: finding module for package github.com/vllm-project/semantic-router/semantic-router/pkg/utils/pii
go: found github.com/vllm-project/semantic-router/semantic-router/pkg/extproc in github.com/vllm-project/semantic-router/semantic-router/pkg/extproc v0.0.0-00010101000000-000000000000
go: found github.com/vllm-project/semantic-router/semantic-router/pkg/config in github.com/vllm-project/semantic-router/semantic-router/pkg/config v0.0.0-00010101000000-000000000000
go: github.com/vllm-project/src/semantic-router/pkg/api imports
	github.com/vllm-project/semantic-router/semantic-router/pkg/config: module ./pkg/config: reading pkg/config/go.mod: open /home/runner/work/semantic-router/semantic-router/src/semantic-router/pkg/config/go.mod: no such file or directory
make: *** [Makefile:71: check-go-mod-tidy] Error 1

@yuluo-yx
Copy link
Contributor Author

go: finding module for package github.com/vllm-project/semantic-router/semantic-router/pkg/api
go: finding module for package github.com/vllm-project/semantic-router/semantic-router/pkg/observability
go: finding module for package github.com/vllm-project/semantic-router/semantic-router/pkg/metrics
go: finding module for package github.com/vllm-project/semantic-router/semantic-router/pkg/services
go: downloading github.com/vllm-project/semantic-router v0.0.0-20250909184249-fe0b5b58a091
go: finding module for package github.com/vllm-project/semantic-router/semantic-router/pkg/cache
go: finding module for package github.com/vllm-project/semantic-router/semantic-router/pkg/tools
go: finding module for package github.com/vllm-project/semantic-router/semantic-router/pkg/utils/classification
go: finding module for package github.com/vllm-project/semantic-router/semantic-router/pkg/utils/http
go: finding module for package github.com/vllm-project/semantic-router/semantic-router/pkg/utils/pii
go: found github.com/vllm-project/semantic-router/semantic-router/pkg/extproc in github.com/vllm-project/semantic-router/semantic-router/pkg/extproc v0.0.0-00010101000000-000000000000
go: found github.com/vllm-project/semantic-router/semantic-router/pkg/config in github.com/vllm-project/semantic-router/semantic-router/pkg/config v0.0.0-00010101000000-000000000000
go: github.com/vllm-project/src/semantic-router/pkg/api imports
	github.com/vllm-project/semantic-router/semantic-router/pkg/config: module ./pkg/config: reading pkg/config/go.mod: open /home/runner/work/semantic-router/semantic-router/src/semantic-router/pkg/config/go.mod: no such file or directory
make: *** [Makefile:71: check-go-mod-tidy] Error 1

got it, I am revising it. I will push it again and turn it into a draft after I succeed.

@yuluo-yx yuluo-yx marked this pull request as draft September 10, 2025 13:05
@yuluo-yx yuluo-yx force-pushed the 0909-yuluo/docs branch 3 times, most recently from 85b3844 to b7a23e3 Compare September 10, 2025 14:26
@yuluo-yx yuluo-yx marked this pull request as ready for review September 10, 2025 14:35
@yuluo-yx
Copy link
Contributor Author

hi @rootfs pls review. thx

@rootfs
Copy link
Collaborator

rootfs commented Sep 10, 2025

merging it now to see if goreportcard can find the repo

@rootfs rootfs merged commit ced6a8e into vllm-project:main Sep 10, 2025
9 checks passed
@yuluo-yx yuluo-yx deleted the 0909-yuluo/docs branch September 10, 2025 14:58
@rootfs
Copy link
Collaborator

rootfs commented Sep 10, 2025

@yuluo-yx not working yet:

$  go get github.com/vllm-project/semantic-router/src/semantic-router
warning: both GOPATH and GOROOT are the same directory (/home/ubuntu/go); see https://go.dev/wiki/InstallTroubleshooting
go: downloading github.com/vllm-project/semantic-router v0.0.0-20250909184249-fe0b5b58a091
go: downloading github.com/vllm-project/semantic-router/src/semantic-router v0.0.0-20250909184249-fe0b5b58a091
go: github.com/vllm-project/semantic-router/src/semantic-router@upgrade (v0.0.0-20250909184249-fe0b5b58a091) requires github.com/vllm-project/semantic-router/src/[email protected]: parsing go.mod:
        module declares its path as: github.com/vllm-project/semantic-router/semantic-router
                but was required as: github.com/vllm-project/semantic-router/src/semantic-router

@yuluo-yx
Copy link
Contributor Author

@yuluo-yx not working yet:

$  go get github.com/vllm-project/semantic-router/src/semantic-router
warning: both GOPATH and GOROOT are the same directory (/home/ubuntu/go); see https://go.dev/wiki/InstallTroubleshooting
go: downloading github.com/vllm-project/semantic-router v0.0.0-20250909184249-fe0b5b58a091
go: downloading github.com/vllm-project/semantic-router/src/semantic-router v0.0.0-20250909184249-fe0b5b58a091
go: github.com/vllm-project/semantic-router/src/semantic-router@upgrade (v0.0.0-20250909184249-fe0b5b58a091) requires github.com/vllm-project/semantic-router/src/[email protected]: parsing go.mod:
        module declares its path as: github.com/vllm-project/semantic-router/semantic-router
                but was required as: github.com/vllm-project/semantic-router/src/semantic-router

got it, let me check.

@yuluo-yx
Copy link
Contributor Author

yuluo-yx commented Sep 10, 2025

@rootfs

Can you try it out again? It works fine here and goreport is also working fine.

my local

# shown @ 🚀 Everything wins. in ~/workspace/golang/test [23:24:06] 
$ go get github.com/vllm-project/semantic-router/src/semantic-router
go: downloading github.com/vllm-project/semantic-router v0.0.0-20250910145752-ced6a8e046f2
go: downloading github.com/vllm-project/semantic-router/src/semantic-router v0.0.0-20250910145752-ced6a8e046f2
go: added github.com/vllm-project/semantic-router/src/semantic-router v0.0.0-20250910145752-ced6a8e046f2

go report

image

@rootfs
Copy link
Collaborator

rootfs commented Sep 10, 2025

@yuluo-yx second time does the charm :D

$ go get github.com/vllm-project/semantic-router/src/semantic-router
warning: both GOPATH and GOROOT are the same directory (/home/ubuntu/go); see https://go.dev/wiki/InstallTroubleshooting
go: downloading github.com/vllm-project/semantic-router/src/semantic-router v0.0.0-20250910145752-ced6a8e046f2
go: downloading github.com/vllm-project/semantic-router v0.0.0-20250910145752-ced6a8e046f2
go: added github.com/vllm-project/semantic-router/src/semantic-router v0.0.0-20250910145752-ced6a8e046f2
```

@yuluo-yx
Copy link
Contributor Author

@yuluo-yx second time does the charm :D

$ go get github.com/vllm-project/semantic-router/src/semantic-router
warning: both GOPATH and GOROOT are the same directory (/home/ubuntu/go); see https://go.dev/wiki/InstallTroubleshooting
go: downloading github.com/vllm-project/semantic-router/src/semantic-router v0.0.0-20250910145752-ced6a8e046f2
go: downloading github.com/vllm-project/semantic-router v0.0.0-20250910145752-ced6a8e046f2
go: added github.com/vllm-project/semantic-router/src/semantic-router v0.0.0-20250910145752-ced6a8e046f2

This seems like a strange problem, maybe you need to get the relevant storage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants