fix(cache): cleanup expired cache entries during update operations #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QIN2DIM
requested review from
Xunzhuo,
rootfs and
wangchen615
as code owners
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@QIN2DIM plz sign the commit, and repush that, thanks! |
QIN2DIM
force-pushed
the
cleanupExpiredEntries
branch
from
63f2772 to
0f03714
Compare
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
Xunzhuo
reviewed
Sep 1, 2025
docker/README.md
Outdated
| git clone <repository-url> | ||
| cd semantic_router | ||
| git clone https://github.com/vllm-project/semantic-router.git | ||
| cd semantic-router |
There was a problem hiding this comment.
can u separate this to another PR, this is not related this the issue. Thanks!
|
@QIN2DIM can you sign?
|
QIN2DIM
force-pushed
the
cleanupExpiredEntries
branch
from
28e098a to
f2422b1
Compare
Signed-off-by: QIN2DIM <[email protected]>
Signed-off-by: QIN2DIM <[email protected]>
QIN2DIM
force-pushed
the
cleanupExpiredEntries
branch
from
f2422b1 to
8e90e37
Compare
Xunzhuo
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix(cache): cleanup expired cache entries during update operations
What this PR does / why we need it:
This PR fixes a memory leak in the semantic cache by ensuring expired entries are cleaned up during
UpdateWithResponseoperations. Previously, in high cache hit rate scenarios, expired entries could accumulate because:FindSimilar(read operations) only logs expired entries but doesn't clean themAddPendingRequestis called less frequently when cache hits are highUpdateWithResponsewas the primary write operation but didn't perform cleanupThe fix adds
cleanupExpiredEntries()call toUpdateWithResponsemethod, making it consistent with other write operations (AddPendingRequestandAddEntry) that already perform cleanup.Which issue(s) this PR fixes:
Release Notes: No