-
Notifications
You must be signed in to change notification settings - Fork 287
fix: LoRA Model Training Configuration and Data Balance #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
715b5c9 to
1262ea5
Compare
|
@OneZero-Y Thanks for the idea. For jailbreak 1:1 mapping, is it necessary? Would that bias towards jailbreak in evaluation? |
| validate_lora_config, | ||
| ) | ||
|
|
||
| # Setup logging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can you add OWNER file in the training_lora directory and add you there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I added it.
Signed-off-by: OneZero-Y <[email protected]> Fix LoRA Model Training Configuration and Data Balance Signed-off-by: OneZero-Y <[email protected]>
|
@rootfs
|
1262ea5 to
17c38ae
Compare
Signed-off-by: OneZero-Y <[email protected]> fix:LoRA Model Training Configuration and Data Balance Signed-off-by: OneZero-Y <[email protected]>
17c38ae to
36ec9ff
Compare
|
@OneZero-Y thank you for the references! They are very helpful! |
|
@OneZero-Y I am still catching up on the LoRA training. This is beyond my working experience :D Merging the PR now |
…#233) * Fix LoRA Model Training Configuration and Data Balance Signed-off-by: OneZero-Y <[email protected]> Fix LoRA Model Training Configuration and Data Balance Signed-off-by: OneZero-Y <[email protected]> * fix:LoRA Model Training Configuration and Data Balance Signed-off-by: OneZero-Y <[email protected]> fix:LoRA Model Training Configuration and Data Balance Signed-off-by: OneZero-Y <[email protected]> --------- Signed-off-by: OneZero-Y <[email protected]> Co-authored-by: Huamin Chen <[email protected]> Signed-off-by: liuhy <[email protected]>
…#233) * Fix LoRA Model Training Configuration and Data Balance Signed-off-by: OneZero-Y <[email protected]> Fix LoRA Model Training Configuration and Data Balance Signed-off-by: OneZero-Y <[email protected]> * fix:LoRA Model Training Configuration and Data Balance Signed-off-by: OneZero-Y <[email protected]> fix:LoRA Model Training Configuration and Data Balance Signed-off-by: OneZero-Y <[email protected]> --------- Signed-off-by: OneZero-Y <[email protected]> Co-authored-by: Huamin Chen <[email protected]>

What type of PR is this?
Fix LoRA Model Training Configuration and Data Balance
What this PR does / why we need it:
Fixed critical configuration and data balance issues in LoRA training scripts that were causing model accuracy problems and training instability.
Key Issues Resolved
Files Modified