Skip to content

Conversation

OneZero-Y
Copy link
Contributor

What type of PR is this?
refactor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Release Notes: Yes/No

Copy link

github-actions bot commented Sep 28, 2025

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 candle-binding

Owners: @rootfs
Files changed:

  • candle-binding/src/classifiers/lora/intent_lora.rs
  • candle-binding/src/classifiers/lora/mod.rs
  • candle-binding/src/classifiers/lora/parallel_engine.rs
  • candle-binding/src/classifiers/lora/pii_lora.rs
  • candle-binding/src/classifiers/lora/security_lora.rs
  • candle-binding/src/classifiers/lora/token_lora.rs
  • candle-binding/src/classifiers/mod.rs
  • candle-binding/src/classifiers/traditional/batch_processor.rs
  • candle-binding/src/classifiers/traditional/mod.rs
  • candle-binding/src/classifiers/traditional/modernbert_classifier.rs
  • candle-binding/src/classifiers/unified.rs
  • candle-binding/src/core/config_loader.rs
  • candle-binding/src/core/mod.rs
  • candle-binding/src/core/similarity.rs
  • candle-binding/src/core/tokenization.rs
  • candle-binding/src/core/unified_error.rs
  • candle-binding/src/ffi/classify.rs
  • candle-binding/src/ffi/init.rs
  • candle-binding/src/ffi/memory.rs
  • candle-binding/src/ffi/memory_safety.rs
  • candle-binding/src/ffi/mod.rs
  • candle-binding/src/ffi/similarity.rs
  • candle-binding/src/ffi/state_manager.rs
  • candle-binding/src/ffi/tokenization.rs
  • candle-binding/src/ffi/types.rs
  • candle-binding/src/ffi/validation.rs
  • candle-binding/src/model_architectures/config.rs
  • candle-binding/src/model_architectures/lora/bert_lora.rs
  • candle-binding/src/model_architectures/lora/lora_adapter.rs
  • candle-binding/src/model_architectures/lora/mod.rs
  • candle-binding/src/model_architectures/mod.rs
  • candle-binding/src/model_architectures/model_factory.rs
  • candle-binding/src/model_architectures/routing.rs
  • candle-binding/src/model_architectures/traditional/base_model.rs
  • candle-binding/src/model_architectures/traditional/bert.rs
  • candle-binding/src/model_architectures/traditional/mod.rs
  • candle-binding/src/model_architectures/traditional/modernbert.rs
  • candle-binding/src/model_architectures/traits.rs
  • candle-binding/src/model_architectures/unified_interface.rs
  • candle-binding/src/utils/memory.rs
  • candle-binding/src/utils/mod.rs
  • candle-binding/src/lib.rs

📁 config

Owners: @rootfs
Files changed:

  • config/config.yaml

vLLM

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.


- Restructure codebase into modular layers (core/, ffi/, model_architectures/, classifiers/)
- Add unified error handling and configuration loading systems
- Implement dual-path architecture for traditional and LoRA models
- Add comprehensive FFI layer with memory safety

Maintains backward compatibility while enabling future model integrations.

Signed-off-by: OneZero-Y <[email protected]>

refactor: Implement modular candle-binding architecture

- Restructure codebase into modular layers (core/, ffi/, model_architectures/, classifiers/)
- Add unified error handling and configuration loading systems
- Implement dual-path architecture for traditional and LoRA models
- Add comprehensive FFI layer with memory safety

Maintains backward compatibility while enabling future model integrations.

Signed-off-by: OneZero-Y <[email protected]>
@OneZero-Y OneZero-Y force-pushed the refactor/modular-candle-binding-architecture branch from 76b941f to 6cd74d5 Compare September 28, 2025 04:53
@OneZero-Y
Copy link
Contributor Author

@rootfs i will refining the rust unit test.

@rootfs rootfs merged commit cfa82ea into vllm-project:feat-candle-refactoring Sep 28, 2025
12 checks passed
@rootfs
Copy link
Collaborator

rootfs commented Sep 28, 2025

@OneZero-Y I'll use this branch for collaboration first and create a PR against main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants