fix: use unified classifier in intent classification API when available #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Classification API's /api/v1/classify/intent endpoint was returning placeholder "general" category responses with 0.5 confidence instead of performing actual classification using the unified classifier. Changes: - Update handleIntentClassification() to check for unified classifier availability first - Use ClassifyIntentUnified() when unified classifier is available - Fall back to legacy ClassifyIntent() when unified classifier not available - Maintain backward compatibility with existing API contract This resolves the issue where the single classification API always returned hardcoded placeholder responses instead of performing actual BERT-based classification. Fixes vllm-project#303 Signed-off-by: Yossi Ovadia <[email protected]>
yossiovadia
requested review from
Xunzhuo,
rootfs and
wangchen615
as code owners
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
rootfs
approved these changes
Oct 2, 2025
Aias00
pushed a commit
to Aias00/semantic-router
that referenced
this pull request
Oct 4, 2025
…le (vllm-project#320) The Classification API's /api/v1/classify/intent endpoint was returning placeholder "general" category responses with 0.5 confidence instead of performing actual classification using the unified classifier. Changes: - Update handleIntentClassification() to check for unified classifier availability first - Use ClassifyIntentUnified() when unified classifier is available - Fall back to legacy ClassifyIntent() when unified classifier not available - Maintain backward compatibility with existing API contract This resolves the issue where the single classification API always returned hardcoded placeholder responses instead of performing actual BERT-based classification. Fixes vllm-project#303 Signed-off-by: Yossi Ovadia <[email protected]> Co-authored-by: Huamin Chen <[email protected]> Signed-off-by: liuhy <[email protected]>
Aias00
pushed a commit
to Aias00/semantic-router
that referenced
this pull request
Oct 4, 2025
…le (vllm-project#320) The Classification API's /api/v1/classify/intent endpoint was returning placeholder "general" category responses with 0.5 confidence instead of performing actual classification using the unified classifier. Changes: - Update handleIntentClassification() to check for unified classifier availability first - Use ClassifyIntentUnified() when unified classifier is available - Fall back to legacy ClassifyIntent() when unified classifier not available - Maintain backward compatibility with existing API contract This resolves the issue where the single classification API always returned hardcoded placeholder responses instead of performing actual BERT-based classification. Fixes vllm-project#303 Signed-off-by: Yossi Ovadia <[email protected]> Co-authored-by: Huamin Chen <[email protected]> Signed-off-by: liuhy <[email protected]>
Aias00
pushed a commit
to Aias00/semantic-router
that referenced
this pull request
Oct 4, 2025
…le (vllm-project#320) The Classification API's /api/v1/classify/intent endpoint was returning placeholder "general" category responses with 0.5 confidence instead of performing actual classification using the unified classifier. Changes: - Update handleIntentClassification() to check for unified classifier availability first - Use ClassifyIntentUnified() when unified classifier is available - Fall back to legacy ClassifyIntent() when unified classifier not available - Maintain backward compatibility with existing API contract This resolves the issue where the single classification API always returned hardcoded placeholder responses instead of performing actual BERT-based classification. Fixes vllm-project#303 Signed-off-by: Yossi Ovadia <[email protected]> Co-authored-by: Huamin Chen <[email protected]> Signed-off-by: liuhy <[email protected]>
Aias00
pushed a commit
to Aias00/semantic-router
that referenced
this pull request
Oct 4, 2025
…le (vllm-project#320) The Classification API's /api/v1/classify/intent endpoint was returning placeholder "general" category responses with 0.5 confidence instead of performing actual classification using the unified classifier. Changes: - Update handleIntentClassification() to check for unified classifier availability first - Use ClassifyIntentUnified() when unified classifier is available - Fall back to legacy ClassifyIntent() when unified classifier not available - Maintain backward compatibility with existing API contract This resolves the issue where the single classification API always returned hardcoded placeholder responses instead of performing actual BERT-based classification. Fixes vllm-project#303 Signed-off-by: Yossi Ovadia <[email protected]> Co-authored-by: Huamin Chen <[email protected]> Signed-off-by: liuhy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Classification API's /api/v1/classify/intent endpoint was returning placeholder "general" category responses with 0.5 confidence instead of performing actual classification using the unified classifier.
Changes:
This resolves the issue where the single classification API always returned hardcoded placeholder responses instead of performing actual BERT-based classification.
Fixes #303