-
Notifications
You must be signed in to change notification settings - Fork 272
Fix Envoy container health check by replacing wget with curl #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: rootfs <[email protected]>
Copilot
AI
changed the title
[WIP] docker-compose failed to start the envoy container
Fix Envoy container health check by replacing wget with curl
Oct 2, 2025
Copilot finished work on behalf of
rootfs
October 2, 2025 23:03
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
rootfs
approved these changes
Oct 2, 2025
Aias00
pushed a commit
to Aias00/semantic-router
that referenced
this pull request
Oct 4, 2025
…oject#323) * Initial plan * Fix Envoy health check by replacing wget with curl Co-authored-by: rootfs <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: rootfs <[email protected]> Signed-off-by: liuhy <[email protected]>
Aias00
pushed a commit
to Aias00/semantic-router
that referenced
this pull request
Oct 4, 2025
…oject#323) * Initial plan * Fix Envoy health check by replacing wget with curl Co-authored-by: rootfs <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: rootfs <[email protected]> Signed-off-by: liuhy <[email protected]>
Aias00
pushed a commit
to Aias00/semantic-router
that referenced
this pull request
Oct 4, 2025
…oject#323) * Initial plan * Fix Envoy health check by replacing wget with curl Co-authored-by: rootfs <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: rootfs <[email protected]> Signed-off-by: liuhy <[email protected]>
Aias00
pushed a commit
to Aias00/semantic-router
that referenced
this pull request
Oct 4, 2025
…oject#323) * Initial plan * Fix Envoy health check by replacing wget with curl Co-authored-by: rootfs <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: rootfs <[email protected]> Signed-off-by: liuhy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Problem
The Envoy container was failing to start due to a health check error. The health check was using
wgetto test the/readyendpoint, but theenvoyproxy/envoy:v1.31.7image does not include thewgetcommand, causing the health check to fail consistently.As reported in the issue, users would see the Envoy container marked as unhealthy when running
docker compose up -d, preventing the service from starting properly.Solution
Replaced the
wgetcommand withcurlin the Envoy service health check configuration indocker-compose.yml. Thecurlcommand is available in the official Envoy image and is the recommended tool for HTTP health checks in containerized environments.Changed:
Previously:
The
-fflag ensurescurlfails on HTTP errors (4xx/5xx responses), making it suitable for health checks. All other health check parameters (interval, timeout, retries, start_period) remain unchanged.Testing
docker-compose.ymlsyntax/readyendpoint on port 19000 is the standard Envoy admin readiness endpointFixes #issue_number
Co-authored-by: yinmin2020 [email protected]
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.