Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 2, 2025

Problem

The Envoy container was failing to start due to a health check error. The health check was using wget to test the /ready endpoint, but the envoyproxy/envoy:v1.31.7 image does not include the wget command, causing the health check to fail consistently.

As reported in the issue, users would see the Envoy container marked as unhealthy when running docker compose up -d, preventing the service from starting properly.

Solution

Replaced the wget command with curl in the Envoy service health check configuration in docker-compose.yml. The curl command is available in the official Envoy image and is the recommended tool for HTTP health checks in containerized environments.

Changed:

healthcheck:
  test: ["CMD", "curl", "-f", "http://localhost:19000/ready"]

Previously:

healthcheck:
  test: ["CMD", "wget", "--no-verbose", "--tries=1", "--spider", "http://localhost:19000/ready"]

The -f flag ensures curl fails on HTTP errors (4xx/5xx responses), making it suitable for health checks. All other health check parameters (interval, timeout, retries, start_period) remain unchanged.

Testing

  • Validated docker-compose.yml syntax
  • The /ready endpoint on port 19000 is the standard Envoy admin readiness endpoint
  • This follows Docker and Envoy best practices for container health checks

Fixes #issue_number

Co-authored-by: yinmin2020 [email protected]

Original prompt

This section details on the original issue you should resolve

<issue_title>docker-compose failed to start the envoy container</issue_title>
<issue_description>Describe the bug
A health check error occurred when the container was running the envoy service,envoy image is envoy:v1.31.7

To Reproduce
Steps to reproduce the behavior:
docker compose up -d

Expected behavior
Start the container normally,
97/5000
The reason is the original envoy image lacks the wget command So http://localhost:19000/ready interface is testing Have unhealthy I manually installed a apt

Screenshots

Image

Additional context
Add any other context about the problem here.
</issue_description>

Comments on the Issue (you are @copilot in this section)

@Xunzhuo /area environment user-experience @Xunzhuo Thank you @yinmin2020 !
Fixes #308

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@netlify
Copy link

netlify bot commented Oct 2, 2025

Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit 59fe31a
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/68df044f3303a6000921238e
😎 Deploy Preview https://deploy-preview-323--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI changed the title [WIP] docker-compose failed to start the envoy container Fix Envoy container health check by replacing wget with curl Oct 2, 2025
Copilot finished work on behalf of rootfs October 2, 2025 23:03
Copilot AI requested a review from rootfs October 2, 2025 23:03
@github-actions
Copy link

github-actions bot commented Oct 2, 2025

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 Root Directory

Owners: @rootfs, @Xunzhuo
Files changed:

  • docker-compose.yml

vLLM

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.

@rootfs rootfs marked this pull request as ready for review October 2, 2025 23:04
@rootfs rootfs requested a review from Xunzhuo as a code owner October 2, 2025 23:04
@rootfs rootfs merged commit ffc5091 into main Oct 2, 2025
10 of 11 checks passed
@rootfs rootfs deleted the copilot/fix-4305dbea-6776-4788-8210-2f7d674456a0 branch October 2, 2025 23:05
Aias00 pushed a commit to Aias00/semantic-router that referenced this pull request Oct 4, 2025
…oject#323)

* Initial plan

* Fix Envoy health check by replacing wget with curl

Co-authored-by: rootfs <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: rootfs <[email protected]>
Signed-off-by: liuhy <[email protected]>
Aias00 pushed a commit to Aias00/semantic-router that referenced this pull request Oct 4, 2025
…oject#323)

* Initial plan

* Fix Envoy health check by replacing wget with curl

Co-authored-by: rootfs <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: rootfs <[email protected]>
Signed-off-by: liuhy <[email protected]>
Aias00 pushed a commit to Aias00/semantic-router that referenced this pull request Oct 4, 2025
…oject#323)

* Initial plan

* Fix Envoy health check by replacing wget with curl

Co-authored-by: rootfs <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: rootfs <[email protected]>
Signed-off-by: liuhy <[email protected]>
Aias00 pushed a commit to Aias00/semantic-router that referenced this pull request Oct 4, 2025
…oject#323)

* Initial plan

* Fix Envoy health check by replacing wget with curl

Co-authored-by: rootfs <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: rootfs <[email protected]>
Signed-off-by: liuhy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docker-compose failed to start the envoy container

3 participants