Skip to content

Conversation

rootfs
Copy link
Collaborator

@rootfs rootfs commented Oct 7, 2025

What type of PR is this?

Design doc for #313 #200

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Release Notes: Yes/No

@rootfs rootfs requested a review from Xunzhuo as a code owner October 7, 2025 19:34
Copy link

netlify bot commented Oct 7, 2025

Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit 5f05096
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/68e56b31923e1100083a5956
😎 Deploy Preview https://deploy-preview-358--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

github-actions bot commented Oct 7, 2025

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 Root Directory

Owners: @rootfs, @Xunzhuo
Files changed:

  • docs/design/additional-prompt-classification-routing.md

vLLM

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a comprehensive design specification for additional prompt classification routing capabilities in the vLLM Semantic Router. The proposal outlines a unified content scanning and routing framework that extends beyond the current BERT-based classification with three new signal sources: keyword-based routing, regex content scanning, and embedding similarity scanning.

Key changes include:

  • Design specification for a multi-signal routing system with both in-tree and out-of-tree execution paths
  • Detailed architecture for signal fusion layer that combines multiple classification approaches
  • Comprehensive configuration schema for the new routing capabilities

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@yuezhu1 yuezhu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly look good to me

- Use BERT results: `bert.category == 'computer science'`
- Combine signals: `keyword.security.matched && bert.category == 'security'`

## Configuration Schema
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can consider adding a configuration schema example for MCP


## Integration with Existing Router

### Request Processing Flow
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, we could add a practical example here for how to integrate with a well recognized router for proposed prompt classification feature.

@Xunzhuo
Copy link
Member

Xunzhuo commented Oct 8, 2025

Looks good, thanks for adding it!

@Xunzhuo Xunzhuo merged commit 1fb0805 into vllm-project:main Oct 8, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants