fix: keep memory cache metrics accurate #372
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix: keep memory cache metrics accurate
What this PR does / why we need it:
Context:
func (c *InMemoryCache) UpdateWithResponse
runsc.cleanupExpiredEntries()
, which can silently drop TTL-expired cache entries, but doesn't callmetrics.UpdateCacheEntries("memory", len(c.entries))
) to refreshCacheEntriesTotal
afterword - leaving the gauge stale until another write(func (c *InMemoryCache) AddEntry
/func (c *InMemoryCache) AddPendingRequest
) happened.Fix:
Close
explicitly zero the gauge after cleaning memory so shutdown reports the correct size.semantic-router/src/semantic-router/pkg/cache/inmemory_cache.go
Lines 120 to 153 in 565c7ab
semantic-router/src/semantic-router/pkg/metrics/metrics.go
Lines 511 to 514 in 565c7ab
Which issue(s) this PR fixes:
Fixes #
Release Notes: Yes/No