fix: remove log tail limit in validation script for model loading detection #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ection The validation script was failing to detect successful model loading because it used --tail=200 to check container logs. Since model containers generate many health check logs after startup, the "model loaded" messages were beyond the 200-line limit. Changes: - Remove --tail=200 from model-a validation (line 98) - Remove --tail=200 from model-b validation (line 110) - Now scans entire log history for "model loaded" message Fixes vllm-project#391 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Yossi Ovadia <[email protected]>
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
rootfs
approved these changes
Oct 11, 2025
joyful-ii-V-I
pushed a commit
to joyful-ii-V-I/semantic-router
that referenced
this pull request
Oct 13, 2025
…ection (vllm-project#392) The validation script was failing to detect successful model loading because it used --tail=200 to check container logs. Since model containers generate many health check logs after startup, the "model loaded" messages were beyond the 200-line limit. Changes: - Remove --tail=200 from model-a validation (line 98) - Remove --tail=200 from model-b validation (line 110) - Now scans entire log history for "model loaded" message Fixes vllm-project#391 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Yossi Ovadia <[email protected]> Co-authored-by: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation script was failing to detect successful model loading because it used --tail=200 to check container logs. Since model containers generate many health check logs after startup, the "model loaded" messages were beyond the 200-line limit.
Changes:
Fixes #391