feat: k8s support and some fixes #407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JaredforReal <[email protected]>
Signed-off-by: JaredforReal <[email protected]>
Signed-off-by: JaredforReal <[email protected]>
Signed-off-by: JaredforReal <[email protected]>
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
rootfs
previously approved these changes
Oct 12, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds Kubernetes support for the dashboard deployment and includes several maintenance improvements.
- Adds comprehensive K8s deployment with ConfigMaps for environment variables and router configuration
- Updates dashboard monitoring page to use new Grafana dashboard path
- Removes Docker network configuration and Go proxy settings for cleaner builds
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| deploy/docker-compose/docker-compose.yml | Removes HuggingFace cache volume and environment variables |
| dashboard/frontend/src/pages/MonitoringPage.tsx | Updates default Grafana dashboard path |
| dashboard/deploy/kubernetes/deployment.yaml | Adds comprehensive K8s deployment with ConfigMaps |
| dashboard/README.md | Updates documentation for K8s support and general improvements |
| dashboard/OWNER | Adds JaredforReal as dashboard owner |
| Dockerfile.extproc | Removes Go proxy settings and download commands |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Xunzhuo
reviewed
Oct 12, 2025
dashboard/OWNER
Outdated
| @@ -0,0 +1,2 @@ | |||
| # Dashboard directory Owners | |||
| @JaredforReal No newline at end of file | |||
There was a problem hiding this comment.
plz add me to this module as well
Signed-off-by: JaredforReal <[email protected]>
Xunzhuo
reviewed
Oct 12, 2025
joyful-ii-V-I
pushed a commit
to joyful-ii-V-I/semantic-router
that referenced
this pull request
Oct 13, 2025
* update README Signed-off-by: JaredforReal <[email protected]> * update README & delete network config Signed-off-by: JaredforReal <[email protected]> * add owner Signed-off-by: JaredforReal <[email protected]> * add dashboard demo to k8s Signed-off-by: JaredforReal <[email protected]> * add Xunzhuo to owner Signed-off-by: JaredforReal <[email protected]> --------- Signed-off-by: JaredforReal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: