refactor(config): move reasoning fields from Category to ModelScore #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move ReasoningDescription and ReasoningEffort from Category level to ModelScore level to enable model-specific reasoning configuration.
**What type of PR is this?**
[Refactoring / Breaking Change]
**What this PR does / why we need it**:
This PR refactors the reasoning configuration structure by moving and fields from the Category level to the ModelScore level. This change enables more granular control over reasoning behavior at the model level rather than the category level.
**Key Changes:**
- Remove and from struct
- These fields now exist in struct (model-level configuration)
- Update to accept parameter
- Update all configuration files to new format (9 files)
- Update Python training scripts to generate new format
- Update TypeScript dashboard to read from best model
- Update all test files
**Breaking Change:**
This is a breaking change with no backward compatibility. Old configuration files must be migrated to the new format.
**Migration:**
Old format:
```yaml
categories:
- name: math
reasoning_description: "..."
reasoning_effort: high
model_scores:
- model: model-a
use_reasoning: true
```
New format:
```yaml
categories:
- name: math
model_scores:
- model: model-a
use_reasoning: true
reasoning_description: "..."
reasoning_effort: high
```
**Testing:**
- All Go tests pass
- All configuration files validated
- TypeScript type checking passes
Signed-off-by: Xunzhuo <[email protected]>
Signed-off-by: bitliu <[email protected]>
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Update generic_category_mapping_test.go to use the new structure where reasoning_effort is a field of ModelScore instead of Category. Signed-off-by: Xunzhuo <[email protected]> Signed-off-by: bitliu <[email protected]>
rootfs
approved these changes
Oct 13, 2025
joyful-ii-V-I
pushed a commit
to joyful-ii-V-I/semantic-router
that referenced
this pull request
Oct 13, 2025
…llm-project#414) * refactor(config): move reasoning fields from Category to ModelScore Move ReasoningDescription and ReasoningEffort from Category level to ModelScore level to enable model-specific reasoning configuration. **What type of PR is this?** [Refactoring / Breaking Change] **What this PR does / why we need it**: This PR refactors the reasoning configuration structure by moving and fields from the Category level to the ModelScore level. This change enables more granular control over reasoning behavior at the model level rather than the category level. **Key Changes:** - Remove and from struct - These fields now exist in struct (model-level configuration) - Update to accept parameter - Update all configuration files to new format (9 files) - Update Python training scripts to generate new format - Update TypeScript dashboard to read from best model - Update all test files **Breaking Change:** This is a breaking change with no backward compatibility. Old configuration files must be migrated to the new format. **Migration:** Old format: ```yaml categories: - name: math reasoning_description: "..." reasoning_effort: high model_scores: - model: model-a use_reasoning: true ``` New format: ```yaml categories: - name: math model_scores: - model: model-a use_reasoning: true reasoning_description: "..." reasoning_effort: high ``` **Testing:** - All Go tests pass - All configuration files validated - TypeScript type checking passes Signed-off-by: Xunzhuo <[email protected]> Signed-off-by: bitliu <[email protected]> * fix(test): move ReasoningEffort to ModelScore in classification test Update generic_category_mapping_test.go to use the new structure where reasoning_effort is a field of ModelScore instead of Category. Signed-off-by: Xunzhuo <[email protected]> Signed-off-by: bitliu <[email protected]> --------- Signed-off-by: Xunzhuo <[email protected]> Signed-off-by: bitliu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
[Refactoring / Breaking Change]
What this PR does / why we need it:
This PR refactors the reasoning configuration structure by moving
reasoning_descriptionandreasoning_effortfields from the Category level to the ModelScore level. This change enables more granular control over reasoning behavior at the model level rather than the category level.Key Changes
ReasoningDescriptionandReasoningEffortfromCategorystructModelScorestruct (model-level configuration)getReasoningEffort()to acceptmodelNameparameterBreaking Change
Migration Guide
Old format:
New format:
Files Changed
Go Backend
src/semantic-router/pkg/config/config.go- Config structure definitionssrc/semantic-router/pkg/extproc/reason_mode_selector.go- Reasoning logicsrc/semantic-router/pkg/extproc/request_handler.go- Request handlingsrc/semantic-router/pkg/extproc/reason_mode_config_test.go- Testssrc/semantic-router/pkg/extproc/reasoning_integration_test.go- Integration testsPython
src/training/model_eval/result_to_config.py- Config generationTypeScript/Dashboard
dashboard/frontend/src/pages/ConfigPage.tsx- UI and interfacesConfiguration Files
config/config.e2e.yaml- E2E test configTesting
Rationale
Pull Request opened by Augment Code with guidance from the PR author