Skip to content

Conversation

samzong
Copy link
Contributor

@samzong samzong commented Oct 14, 2025

What type of PR is this?

chore: remove legacy mock/real vLLM test modes and Makefile

What this PR does / why we need it:
Drop the --mock / --real flags from e2e-tests/run_all_tests.py and remove
legacy start/stop and test targets for mock/real vLLM servers from the
tools/make/build-run-test.mk. Simplifies the e2e workflow to rely on the
LLM Katan flow and the manual start/run pattern.

Which issue(s) this PR fixes:

Fixes #420

Release Notes: Yes

Copy link

netlify bot commented Oct 14, 2025

Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit bccd2d0
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/68ee0e3ad2ff670008ddbefd
😎 Deploy Preview https://deploy-preview-421--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

github-actions bot commented Oct 14, 2025

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 e2e-tests

Owners: @yossiovadia
Files changed:

  • e2e-tests/run_all_tests.py

📁 tools

Owners: @yuluo-yx, @rootfs, @Xunzhuo
Files changed:

  • tools/make/build-run-test.mk

vLLM

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.

@samzong samzong force-pushed the chore/remove-obsolete-vllm-e2e-targets branch from 098c5fc to bccd2d0 Compare October 14, 2025 08:47
@samzong samzong marked this pull request as ready for review October 14, 2025 08:48
@rootfs
Copy link
Collaborator

rootfs commented Oct 14, 2025

@yossiovadia PTAL, thanks

@rootfs rootfs requested review from Copilot and yossiovadia October 14, 2025 12:50
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes legacy test infrastructure for mock and real vLLM server modes from the e2e testing workflow. The changes simplify the testing process by consolidating to use only the LLM Katan flow, which provides lightweight real model testing.

Key changes:

  • Removed --mock and --real command-line flags from the test runner
  • Eliminated legacy Makefile targets for starting/stopping mock and real vLLM servers
  • Streamlined to a single manual workflow using LLM Katan servers

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tools/make/build-run-test.mk Removed legacy Makefile targets for mock/real vLLM server management and testing
e2e-tests/run_all_tests.py Removed command-line arguments and mode detection logic for mock/real vLLM testing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@rootfs rootfs merged commit 4d6d85f into vllm-project:main Oct 15, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop Legacy vLLM E2E Targets and Flags

4 participants