-
Notifications
You must be signed in to change notification settings - Fork 242
deploy: update docker compose file #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
yuluo-yx
commented
Oct 14, 2025
Signed-off-by: yuluo-yx <[email protected]>
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
ptal @JaredforReal |
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
|
@yuluo-yx can you fix the markdown link? |
|
We have exported env at the top of the # Default docker compose environment
# Point Compose to the relocated main stack by default; override by exporting COMPOSE_FILE
export COMPOSE_FILE ?= deploy/docker-compose/docker-compose.yml
# Keep a stable project name so network/volume names are predictable across runs
export COMPOSE_PROJECT_NAME ?= semantic-routerso |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should revert changes in makefile? Just fix the guide in markdown file?
|
I'm gonna take care of the make file and make it clearer |
Should we resubmit a PR for this? Is the current PR remaining unchanged? |
Is this referring to the ci error in this pr? It seems that it is not caused by the problem with markdown lint. |
|
@yuluo-yx @JaredforReal is it ready to go? |
|
we should revert the changes in make file, and keep the changes in docs @yuluo-yx |
Signed-off-by: yuluo-yx <[email protected]>
revert it. |
it's ready merge. |
|
Thanks |
