Skip to content

Conversation

@yuluo-yx
Copy link
Contributor

image

@netlify
Copy link

netlify bot commented Oct 14, 2025

Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit a1e89e4
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/68efaa71363f2f0008f99c1b
😎 Deploy Preview https://deploy-preview-425--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@yuluo-yx
Copy link
Contributor Author

ptal @JaredforReal

@github-actions
Copy link

github-actions bot commented Oct 14, 2025

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 website

Owners: @Xunzhuo, @rootfs, @yuluo-yx
Files changed:

  • website/docs/installation/docker-compose.md
  • website/docs/tutorials/observability/metrics.md

vLLM

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.

rootfs
rootfs previously approved these changes Oct 14, 2025
@rootfs
Copy link
Collaborator

rootfs commented Oct 14, 2025

@yuluo-yx can you fix the markdown link?

@JaredforReal
Copy link
Collaborator

JaredforReal commented Oct 14, 2025

We have exported env at the top of the docker.mk

# Default docker compose environment
# Point Compose to the relocated main stack by default; override by exporting COMPOSE_FILE
export COMPOSE_FILE ?= deploy/docker-compose/docker-compose.yml
# Keep a stable project name so network/volume names are predictable across runs
export COMPOSE_PROJECT_NAME ?= semantic-router

so make docker-compose-up in project root dir is working well.
You can override with command like: COMPOSE_FILE=path/to/other.yml make docker-compose-up or docker compose -f path/to/other.yml up
This PR can make things clearer :)

Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should revert changes in makefile? Just fix the guide in markdown file?

@JaredforReal
Copy link
Collaborator

I'm gonna take care of the make file and make it clearer

@yuluo-yx
Copy link
Contributor Author

I'm gonna take care of the make file and make it clearer

Should we resubmit a PR for this? Is the current PR remaining unchanged?

@yuluo-yx
Copy link
Contributor Author

yuluo-yx commented Oct 14, 2025

@yuluo-yx can you fix the markdown link?

Is this referring to the ci error in this pr? It seems that it is not caused by the problem with markdown lint.

@rootfs
Copy link
Collaborator

rootfs commented Oct 15, 2025

@yuluo-yx @JaredforReal is it ready to go?

@JaredforReal
Copy link
Collaborator

JaredforReal commented Oct 15, 2025

we should revert the changes in make file, and keep the changes in docs @yuluo-yx
I have added llm-katan to docker-compose-up, let docker-compose-up-core take over the original docker-compose-up

Signed-off-by: yuluo-yx <[email protected]>
@yuluo-yx
Copy link
Contributor Author

we should revert the changes in make file, and keep the changes in docs @yuluo-yx I have added llm-katan to docker-compose-up, let docker-compose-up-core take over the original docker-compose-up

revert it.

@yuluo-yx
Copy link
Contributor Author

@yuluo-yx @JaredforReal is it ready to go?

it's ready merge.

@JaredforReal
Copy link
Collaborator

Thanks

@rootfs rootfs merged commit b5e81f4 into vllm-project:main Oct 15, 2025
9 checks passed
@yuluo-yx yuluo-yx deleted the 1014-yuluo/chore branch October 15, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants