Skip to content

fix:add binary attributes for image files to prevent line ending conversion #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
Merged

fix:add binary attributes for image files to prevent line ending conversion #459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
# Auto detect text files and perform LF normalization
* text=auto
* text eol=lf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test this PR on macOS:

Affected files:

(base) ➜  semantic-router git:(main) ✗ git rm --cached -r -f .
(base) ➜  semantic-router git:(main) ✗ git add .
(base) ➜  semantic-router git:(main) ✗ git status
On branch main
Your branch is up to date with 'origin/main'.

Changes to be committed:
  (use "git restore --staged <file>..." to unstage)
	modified:   .gitattributes
	modified:   .github/workflows/docker-publish.yml

I tested with my changes on macOS,

# Auto detect text files and perform LF normalization
* text=auto eol=lf

and it got same result.

(base) ➜  semantic-router git:(main) ✗ git diff .github/workflows/docker-publish.yml

output:

image


# Binary files - treat as binary, no line ending conversion
*.png binary
*.jpg binary
*.jpeg binary
*.gif binary
*.ico binary
*.svg binary
Loading