-
Notifications
You must be signed in to change notification settings - Fork 276
chore: upgrade rust version to 1.90 in all related Dockerfiles #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR downgrades the Rust version from 1.85 to 1.90 across Dockerfiles to align with the project's minimum Rust version requirement of 1.90.0 for Candle bindings support.
- Standardized Rust version to 1.90 in Docker base images
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Dockerfile.extproc.cross | Updated Rust base image from 1.85 to 1.90 for cross-compilation builder |
| Dockerfile.extproc | Updated Rust base image from 1.85 to 1.90 for standard builder |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: carlory <[email protected]>
dccc689 to
d9da6b7
Compare
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
|
@rootfs rebased. |
|
@carlory can you update this too to make sure Rust 1.9 is fully tested? |
Signed-off-by: carlory <[email protected]>
ada8c8c to
431e98e
Compare
|
After upgrading rust image version to 1.90, it will fails on centos:stream9 due to incompatibility with glibc. error message: readelf output: ldd version on centos:streamX ldd version on rust:X It seems that this issue can be solved by replacing centos:stream9 with centos:stream10. But it is not a good solution because the ldd version on rust:1.90 is higher than the ldd version on centos:stream10. Is it possible to change rust-builder image to Do you have any better suggestion? @rootfs |
|
@carlory maybe some crates also need upgrade. I am in the process of upgrading candle from 0.8.4 to latest, stay tuned. |
|
@carlory it looks new rust may have more restriction per https://github.com/vllm-project/semantic-router/actions/runs/18881201529/job/53884511892?pr=549 I don't have this issue on my end with Rust 1.75. |
|
@carlory 1.90 actually works with newer candle. When you fix the CI, let's merge this PR. |
|
@JaredforReal the kubernetes test failed on timeout. The init container failed to download the models before the readiness probe failed. We may need longer probe interval. |

What this PR does / why we need it:
related-to #176
Which issue(s) this PR fixes:
Fixes #
Release Notes: Yes/No