Skip to content

chore: 1) install rust if not present 2) expose bench params in env var #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 5, 2025
Merged

chore: 1) install rust if not present 2) expose bench params in env var #54

merged 5 commits into from
Sep 5, 2025

Conversation

@rootfs
Copy link
Collaborator

@rootfs rootfs commented Sep 4, 2025 •
edited
Loading

What type of PR is this?

  • Add rust installation if it is not installed yet, per doc instructions
  • Expose bench params in env var

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Release Notes: Yes/No

@rootfs rootfs requested a review from Xunzhuo as a code owner September 4, 2025 17:24
@github-actions
Copy link

github-actions bot commented Sep 4, 2025 •
edited
Loading

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 Root Directory

Owners: @rootfs, @Xunzhuo
Files changed:

  • Makefile

📁 bench

Owners: @yuezhu1, @Xunzhuo
Files changed:

  • bench/run_bench.sh

This comment was automatically generated based on the OWNER files in the repository.

@netlify
Copy link

netlify bot commented Sep 4, 2025 •
edited
Loading

✅ Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit 6f365e3
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/68ba1638d1f2c600082fed77
😎 Deploy Preview https://deploy-preview-54--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rootfs rootfs requested a review from yuezhu1 as a code owner September 4, 2025 20:33
@rootfs rootfs changed the title chore: install rust if not present chore: 1) install rust if not present 2) expose bench params in env var Sep 4, 2025
@rootfs rootfs mentioned this pull request Sep 4, 2025
Open
Xunzhuo
Xunzhuo approved these changes Sep 5, 2025
View reviewed changes
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Xunzhuo Xunzhuo merged commit 99736b0 into vllm-project:main Sep 5, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xunzhuo Xunzhuo Xunzhuo approved these changes

@yuezhu1 yuezhu1 Awaiting requested review from yuezhu1 yuezhu1 is a code owner

Assignees

@rootfs rootfs

@yuezhu1 yuezhu1

@Xunzhuo Xunzhuo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rootfs @Xunzhuo @yuezhu1