Skip to content

Conversation

@JaredforReal
Copy link
Collaborator

@JaredforReal JaredforReal commented Nov 1, 2025

Which issue(s) this PR fixes:

Fixes #568

# no more warning
(vllm) jaredwen@JareddeMacBook-Air semantic-router % make help
Intelligent Mixture-of-Models Router for Efficient LLM Inference.

Available targets:
  Build targets:
    all                     - Build everything (default)
    build                   - Build Rust library and Go router
    rust                    - Build only the Rust library
    build-router            - Build only the Go router
    clean                   - Clean build artifacts

  Run targets:
    run-router              - Run the router (CONFIG_FILE=config/config.yaml)
    run-router-e2e          - Run the router with e2e config (config/config.e2e.yaml)
    run-envoy               - Run Envoy proxy

  Test targets:
    test                    - Run all tests
    test-rust               - Run Rust unit tests
    test-rust-module MODULE=<name> - Run specific Rust module tests
    test-binding            - Test candle-binding
    test-semantic-router    - Test semantic router
    test-category-classifier - Test category classifier
    test-pii-classifier     - Test PII classifier
    test-jailbreak-classifier - Test jailbreak classifier

  E2E Test targets:
    start-llm-katan         - Start LLM Katan servers for e2e tests
    test-e2e-vllm           - Run e2e tests with LLM Katan servers

  Milvus targets (CONTAINER_RUNTIME=docker|podman):
    start-milvus            - Start Milvus container for testing
    stop-milvus             - Stop and remove Milvus container
    restart-milvus          - Restart Milvus container
    milvus-status           - Check Milvus container status
    clean-milvus            - Stop container and clean data
    test-milvus-cache       - Test cache with Milvus backend
    test-semantic-router-milvus - Test router with Milvus cache
    start-milvus-ui         - Start Milvus UI to browse data
    stop-milvus-ui          - Stop and remove Milvus UI container
    Example: CONTAINER_RUNTIME=podman make start-milvus

  Demo targets:
    test-auto-prompt-reasoning - Test reasoning mode
    test-auto-prompt-no-reasoning - Test normal mode
    test-pii                - Test PII detection
    test-prompt-guard       - Test jailbreak detection
    test-tools              - Test tool auto-selection

  Documentation targets:
    docs-dev                - Start documentation dev server
    docs-build              - Build documentation
    docs-serve              - Serve built documentation
    docs-clean              - Clean documentation artifacts

  Environment variables:
    CONTAINER_RUNTIME       - Container runtime (docker|podman, default: docker)
    CONFIG_FILE             - Config file path (default: config/config.yaml)
    VLLM_ENDPOINT           - vLLM endpoint URL for testing

  Usage examples:
    make start-milvus                    # Use Docker (default)
    CONTAINER_RUNTIME=podman make start-milvus  # Use Podman
    CONFIG_FILE=custom.yaml make run-router     # Use custom config
# pre-commit result
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for added large files..............................................Passed
go fmt...................................................................Passed
shellcheck...............................................................Passed
go lint..................................................................Passed
md fmt...................................................................Passed
yaml/yml fmt.............................................................Passed
js/ts lint...............................................................Passed
cargo fmt................................................................Passed
cargo check..............................................................Passed
black....................................................................Passed
make[1]: Leaving directory '/home/runner/work/semantic-router/semantic-router'

Signed-off-by: JaredforReal <[email protected]>
@netlify
Copy link

netlify bot commented Nov 1, 2025

Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit 55a3420
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/6905a2143e9cd30008b36441
😎 Deploy Preview https://deploy-preview-569--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 1, 2025

Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit 5a88964
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/6905afdd3e9cd30008b41b66
😎 Deploy Preview https://deploy-preview-569--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Nov 1, 2025

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 Root Directory

Owners: @rootfs, @Xunzhuo
Files changed:

  • .github/workflows/pre-commit.yml
  • README.md
  • scripts/quickstart.sh

📁 tools

Owners: @yuluo-yx, @rootfs, @Xunzhuo
Files changed:

  • tools/make/envs.mk
  • tools/make/linter.mk
  • tools/make/pre-commit.mk

vLLM

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.

Signed-off-by: JaredforReal <[email protected]>
shellcheck to fix pre-commit error

Signed-off-by: JaredforReal <[email protected]>
Signed-off-by: JaredforReal <[email protected]>
@JaredforReal JaredforReal changed the title fix: make command warning fix: make command warning & CI pre-commit errpor Nov 1, 2025
@JaredforReal JaredforReal changed the title fix: make command warning & CI pre-commit errpor fix: make command warning & CI pre-commit error Nov 1, 2025
Signed-off-by: JaredforReal <[email protected]>
@JaredforReal
Copy link
Collaborator Author

cc @yuluo-yx

@yuluo-yx
Copy link
Contributor

yuluo-yx commented Nov 1, 2025

I think this place could also be restored?

@Xunzhuo Xunzhuo merged commit 8c3d707 into vllm-project:main Nov 1, 2025
10 checks passed
@JaredforReal JaredforReal deleted the fix/make branch November 1, 2025 07:14
@JaredforReal
Copy link
Collaborator Author

@yuluo-yx This PR did not touch make/common.mk, I don't get what u mean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

when run make help cmd, CI variable is not defined.

4 participants