-
Notifications
You must be signed in to change notification settings - Fork 296
Slim precommit image #701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Slim precommit image #701
Conversation
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
3640555 to
6b3a340
Compare
Signed-off-by: samzong <[email protected]>
6b3a340 to
a8a3d62
Compare
|
After a while of trying, it's hard to meet my expectations; would like to ask for advice. I’ve squeezed the pre-commit image from 3.58 GB to 2.75 GB, but any further cuts start breaking Go/Rust checks. To keep all Go/Rust hooks and still slim meaningfully, the only practical option is to run Go/Rust hooks via separate language: docker_image entries, each pointing to a minimal go (gofmt + golangci-lint) and rust (cargo + rustfmt + toolchain) image. The main pre-commit image would then keep only Python linters + markdownlint + shellcheck. This should shave off a few size and speed pulls/builds, at the cost of maintaining two small images and slightly more config. If you agree that I can implement the separation of images in this PR; or accept the current situation, I will focus my energy on other matters. |
|
emm~ I don't think it's necessary; it would only make submitting a PR more difficult. 🤔 |


Record some...
FILL IN THE PR DESCRIPTION HERE
FIX #693 (link existing issues this PR will resolve)
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
-swhen doinggit commit[Bugfix],[Feat], and[CI].Detailed Checklist (Click to Expand)
Thank you for your contribution to semantic-router! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Feat]for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).[Router]for changes to thevllm_router(e.g., routing algorithm, router observability, etc.).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
pre-committo format your code. SeeREADME.mdfor installation.DCO and Signed-off-by
When contributing changes to this project, you must agree to the DCO. Commits must include a
Signed-off-by:header which certifies agreement with the terms of the DCO.Using
-swithgit commitwill automatically add this header.What to Expect for the Reviews