Skip to content

Conversation

@srampal
Copy link
Contributor

@srampal srampal commented Nov 21, 2025

  • Make sure the code changes pass the pre-commit checks.
  • Sign-off your commit by using -s when doing git commit
  • Try to classify PRs for easy understanding of the type of changes, such as [Bugfix], [Feat], and [CI].
Detailed Checklist (Click to Expand)

Thank you for your contribution to semantic-router! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • Code Quality

    The PR need to meet the following code quality standards:

    • Pass all linter checks. Please use pre-commit to format your code. See README.md for installation.
    • The code need to be well-documented to ensure future contributors can easily understand the code.
    • Please include sufficient tests to ensure the change is stay correct and robust. This includes both unit tests and integration tests.

    DCO and Signed-off-by

    When contributing changes to this project, you must agree to the DCO. Commits must include a Signed-off-by: header which certifies agreement with the terms of the DCO.

    Using -s with git commit will automatically add this header.

    What to Expect for the Reviews

@netlify
Copy link

netlify bot commented Nov 21, 2025

Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit 8d233f8
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/6920002309f8320008c28328
😎 Deploy Preview https://deploy-preview-711--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Nov 21, 2025

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 deploy

Owners: @rootfs, @Xunzhuo
Files changed:

  • deploy/kubernetes/istio/config.yaml
  • deploy/kubernetes/istio/deployment.yaml
  • deploy/kubernetes/llmd-base/llmd+public-llm/README.md
  • deploy/kubernetes/llmd-base/llmd+public-llm/config.yaml.openai
  • deploy/kubernetes/llmd-base/llmd+public-llm/httproute-openai.template

vLLM

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.

templating logic of the OPENAI_API_KEY

Signed-off-by: Sanjeev Rampal <[email protected]>
@srampal srampal marked this pull request as ready for review November 21, 2025 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants