Skip to content

Conversation

@yehudit1987
Copy link
Contributor

Add comprehensive test suite for embedding model infrastructure covering
concurrency, memory, and performance. Includes 29 integration tests,
GitHub Actions workflow, and complete documentation.

  • Concurrency tests: race conditions, deadlocks, goroutine leaks
  • Memory tests: leak detection, growth analysis, GC behavior
  • Performance tests: throughput, latency, concurrent performance
  • CI workflow with model downloads and automated testing
  • Makefile targets: test-embedding, bench-embedding
  • Comprehensive test documentation and helper utilities

Resolve issue: #715

@netlify
Copy link

netlify bot commented Nov 24, 2025

Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit db0a6dd
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/69256c1a3cd79e0008e31600
😎 Deploy Preview https://deploy-preview-729--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@yehudit1987 yehudit1987 force-pushed the embedding_tests branch 2 times, most recently from fe1d06d to fd964dd Compare November 24, 2025 17:47
@github-actions
Copy link

github-actions bot commented Nov 24, 2025

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 Root Directory

Owners: @rootfs, @Xunzhuo
Files changed:

  • .github/workflows/integration-tests-embedding.yml

📁 src

Owners: @rootfs, @Xunzhuo, @wangchen615
Files changed:

  • src/semantic-router/test/integration/README.md
  • src/semantic-router/test/integration/embedding_concurrency_test.go
  • src/semantic-router/test/integration/embedding_memory_test.go
  • src/semantic-router/test/integration/embedding_performance_test.go
  • src/semantic-router/test/integration/embedding_test_helpers.go

📁 tools

Owners: @yuluo-yx, @rootfs, @Xunzhuo
Files changed:

  • tools/make/build-run-test.mk

vLLM

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.

@yehudit1987 yehudit1987 force-pushed the embedding_tests branch 2 times, most recently from dd9cf1e to 0186df2 Compare November 24, 2025 18:17
@rootfs
Copy link
Collaborator

rootfs commented Nov 24, 2025

@OneZero-Y PTAL, thanks

Signed-off-by: Yehudit Kerido <[email protected]>
@yehudit1987 yehudit1987 marked this pull request as ready for review November 25, 2025 10:22
@yehudit1987
Copy link
Contributor Author

Optional: HF_TOKEN Configuration

This PR's tests support graceful fallback and pass without HF_TOKEN (Qwen3-only mode).

To enable full Gemma model testing, maintainers can add HF_TOKEN as a repository secret after accepting the Gemma model license.

This enables the BenchmarkEmbedding_ModelComparison benchmark and validates both model paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants