fix the ci test for quickstart.sh script, In case we had failure in downloading embeddinggemma-300m, to fallback into minimal models #737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ownload embeddinggemma-300m, fall back to minimal models Signed-off-by: Senan Zedan <[email protected]>
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
Contributor
Author
|
@Xunzhuo - could you please review? |
Restore pull_request and push triggers for the Integration Test [Docker Compose] workflow that were removed in commit 0e3a669. The workflow now runs on: - Pull requests to main (excluding website/** and **.md) - Pushes to main (excluding website/** and **.md) - Manual workflow_dispatch triggers This ensures the docker-compose integration test runs automatically for all PRs, catching issues before merge. The test now passes with the fallback logic in quickstart.sh that handles gated model failures. Signed-off-by: Senan Zedan <[email protected]>
Xunzhuo
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: add fallback to minimal models on gated model auth failure
Quickstart script now falls back to minimal models when embeddinggemma-300m
download fails due to authentication, fixing CI test failures.