Skip to content

Conversation

@cryo-zd
Copy link
Contributor

@cryo-zd cryo-zd commented Sep 7, 2025

What type of PR is this?

chore: Use (*OpenAIRouter)(nil) for interface compliance check

What this PR does / why we need it:
This avoids unnecessary allocation at package init and makes the intent clearer, following common Go idioms.

@netlify
Copy link

netlify bot commented Sep 7, 2025

Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit 0caee8f
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/68bdab38a804c6000931d632
😎 Deploy Preview https://deploy-preview-77--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@cryo-zd cryo-zd changed the title Use (*OpenAIRouter)(nil) for interface compliance check chore: Use (*OpenAIRouter)(nil) for interface compliance check Sep 7, 2025
@github-actions
Copy link

github-actions bot commented Sep 7, 2025

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 src

Owners: @rootfs, @Xunzhuo, @wangchen615
Files changed:

  • src/semantic-router/pkg/extproc/router.go

This comment was automatically generated based on the OWNER files in the repository.

@rootfs
Copy link
Collaborator

rootfs commented Sep 7, 2025

@cryo-zd nice catch. Would you like to take one step further to add go vet in the CI

@rootfs rootfs merged commit 769fbe3 into vllm-project:main Sep 7, 2025
10 checks passed
@cryo-zd
Copy link
Contributor Author

cryo-zd commented Sep 7, 2025

@cryo-zd nice catch. Would you like to take one step further to add go vet in the CI

My pleasure. I plan to introduce a separate vet target in the Makefile, and then make make test depend on it.

Does this approach sound reasonable to you?

@cryo-zd cryo-zd deleted the type branch September 7, 2025 16:25
@rootfs
Copy link
Collaborator

rootfs commented Sep 7, 2025

sounds good!

@cryo-zd cryo-zd mentioned this pull request Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants