-
Notifications
You must be signed in to change notification settings - Fork 277
feat(config): watch config file and hot-reload router without restart #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| }) | ||
| } | ||
|
|
||
| for { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a followup pr to test config file update under different scenarios?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#92 for tracking
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
Signed-off-by: Jintao Zhang <[email protected]>
732a9e6 to
1f98862
Compare
Signed-off-by: Jintao Zhang <[email protected]>
1f98862 to
784d67b
Compare
|
for this regard, I have an idea, why don't we use viper directly? 🤔 |
I don't want to introduce viper because it's over-engineered and has some irrelevant dependencies. Here we need more precise control, and we don't need the complex templates and environment variable binding features in viper. |

What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #82
Release Notes: Yes/No