Skip to content

Conversation

@tao12345666333
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #82

Release Notes: Yes/No

@netlify
Copy link

netlify bot commented Sep 8, 2025

Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit 784d67b
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/68beef9dde019b0008eb71e9
😎 Deploy Preview https://deploy-preview-84--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

})
}

for {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a followup pr to test config file update under different scenarios?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#92 for tracking

@github-actions
Copy link

github-actions bot commented Sep 8, 2025

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 src

Owners: @rootfs, @Xunzhuo, @wangchen615
Files changed:

  • src/semantic-router/pkg/config/parse_configfile_test.go
  • src/semantic-router/go.mod
  • src/semantic-router/go.sum
  • src/semantic-router/pkg/config/config.go
  • src/semantic-router/pkg/extproc/router.go
  • src/semantic-router/pkg/extproc/server.go

vLLM

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.

@yuluo-yx
Copy link
Contributor

yuluo-yx commented Sep 8, 2025

hi, @tao12345666333 @rootfs

for this regard, I have an idea, why don't we use viper directly? 🤔

https://github.com/spf13/viper

@rootfs rootfs merged commit 9bca691 into vllm-project:main Sep 8, 2025
9 checks passed
@tao12345666333 tao12345666333 deleted the feat-watch-config branch September 8, 2025 23:57
@tao12345666333
Copy link
Contributor Author

for this regard, I have an idea, why don't we use viper directly? 🤔

https://github.com/spf13/viper

I don't want to introduce viper because it's over-engineered and has some irrelevant dependencies.

Here we need more precise control, and we don't need the complex templates and environment variable binding features in viper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Router should watch config yaml and load it when the config is updated

5 participants