docs: semantic cache stale types and implementation #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, really impressive project! Not only a product that solves real problem by reducing a cost, but also production grade software with envoy, low latency, cache and also in go!
What type of PR is this?
Outdated documentation
What this PR does / why we need it:
When I was reading docs I noticed missing
similarityThreshold
inSemanticCache
. Upon further investigation seems that the implementation in the docs while still conceptually correct is slightly different in the code.