Skip to content

Conversation

gluonfield
Copy link
Contributor

@gluonfield gluonfield commented Aug 31, 2025

First of all, really impressive project! Not only a product that solves real problem by reducing a cost, but also production grade software with envoy, low latency, cache and also in go!

What type of PR is this?
Outdated documentation

What this PR does / why we need it:
When I was reading docs I noticed missing similarityThreshold in SemanticCache. Upon further investigation seems that the implementation in the docs while still conceptually correct is slightly different in the code.

Signed-off-by: Augustinas Malinauskas <[email protected]>
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for clean up. this is obviously out dated

@Xunzhuo Xunzhuo merged commit a44932b into vllm-project:main Aug 31, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants