Skip to content

Conversation

SunnyLee151064
Copy link
Contributor

@SunnyLee151064 SunnyLee151064 commented Aug 12, 2025

What this PR does / why we need it?

Delete dumplicate codes and fix a bug

Does this PR introduce any user-facing change?

No

How was this patch tested?

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request includes two changes: a bug fix and a code cleanup. The bug fix in vllm_ascend/quantization/quant_config.py adds a check to ensure the moe attribute exists on a FusedMoE layer before accessing it, preventing a potential AttributeError. The code cleanup in vllm_ascend/worker/model_runner_v1.py removes a redundant call to _check_dbo_is_valid. Both changes are correct and improve the robustness and clarity of the code.

Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.74%. Comparing base (1a70564) to head (45b652f).
⚠️ Report is 45 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2341      +/-   ##
==========================================
- Coverage   76.35%   75.74%   -0.61%     
==========================================
  Files         117      118       +1     
  Lines       13371    13525     +154     
==========================================
+ Hits        10209    10245      +36     
- Misses       3162     3280     +118     
Flag Coverage Δ
unittests 75.74% <100.00%> (-0.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant