Fix the accuracy issues caused by the mrope operator #2355
Closed
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Fix precision and inference length issues with MRoPE operator in multi-image long sequences for Qwen2.5-VL-7B
This PR addresses two critical issues observed with the MRoPE operator:
Root cause analysis revealed that most CANN operators internally perform contiguous() operations to ensure accessing contiguous data during computations. However, the ”positions“ tensor was missing this crucial step, leading to incorrect memory access and corrupted values during operator calculations.
The fix adds a contiguous() operation on the positions tensor at the Python level, ensuring proper memory layout consistency with other tensor operations.
Does this PR introduce any user-facing change?
no
How was this patch tested?
Comparing the accuracy of V0 and V1, the error meets the standard
