-
Notifications
You must be signed in to change notification settings - Fork 389
refact attn metadata build #2360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the attention metadata building process by introducing AscendCommonAttentionMetadata
and TorchairCommonAttentionMetadata
dataclasses. This is a positive change that improves code structure and decouples components from the main runner. However, the refactoring has introduced a few critical issues where the runner
object is still being accessed after its removal from class initializers, which will lead to AttributeError
exceptions. Additionally, there are some inconsistencies in the new dataclasses that will cause TypeError
exceptions. I've provided detailed comments and suggestions to fix these issues.
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: weiguihua2 <[email protected]> refact attn metadata build Signed-off-by: weiguihua2 <[email protected]> refact attn metadata build Signed-off-by: weiguihua2 <[email protected]> refact attn metadata build Signed-off-by: weiguihua2 <[email protected]> refact attn metadata build Signed-off-by: weiguihua2 <[email protected]> refact attn metadata build Signed-off-by: weiguihua2 <[email protected]> refact attn metadata build Signed-off-by: weiguihua2 <[email protected]> refact attn metadata build Signed-off-by: weiguihua2 <[email protected]> refact attn metadata build Signed-off-by: weiguihua2 <[email protected]> refact attn metadata build Signed-off-by: weiguihua2 <[email protected]> refact attn metadata build Signed-off-by: weiguihua2 <[email protected]> refact attn metadata build Signed-off-by: weiguihua2 <[email protected]> refact attn metadata build Signed-off-by: weiguihua2 <[email protected]> refact attn metadata build Signed-off-by: weiguihua2 <[email protected]> refact model runner Signed-off-by: weiguihua2 <[email protected]> refact model runner Signed-off-by: weiguihua2 <[email protected]> refact model runner Signed-off-by: weiguihua2 <[email protected]> refact model runner Signed-off-by: weiguihua2 <[email protected]>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
What this PR does / why we need it?
Does this PR introduce any user-facing change?
NO
How was this patch tested?
Environmental measurement