Skip to content

Conversation

Potabk
Copy link
Collaborator

@Potabk Potabk commented Sep 27, 2025

What this PR does / why we need it?

Since the newest vllm commit has deprecated the arg --endpoint-type, we should use --backend instead

Does this PR introduce any user-facing change?

How was this patch tested?

Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@Potabk Potabk added ready-for-test start test by label for PR performance-test enable performance test for PR labels Sep 27, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the benchmark configuration by replacing the deprecated endpoint_type parameter with backend in benchmarks/tests/serving-tests.json. This change aligns the benchmark tests with the latest version of vllm, which has deprecated the old argument. The modification is correctly and consistently applied across the test configurations. The change is straightforward and addresses the stated purpose of the pull request effectively.

@Yikun Yikun added performance-test enable performance test for PR ready-for-test start test by label for PR and removed ready-for-test start test by label for PR performance-test enable performance test for PR labels Sep 27, 2025
Signed-off-by: wangli <[email protected]>
@Potabk Potabk added ready-for-test start test by label for PR performance-test enable performance test for PR and removed ready-for-test start test by label for PR performance-test enable performance test for PR labels Sep 28, 2025
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-conflicts performance-test enable performance test for PR ready-for-test start test by label for PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants