Drop 0.10.2 #3284
Merged
Drop 0.10.2 #3284
+202
−653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wangxiyuan <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively removes support for vLLM v0.10.2, simplifying the codebase by eliminating conditional logic and outdated code paths. The changes are consistent across all modified files, correctly updating API calls and removing obsolete functions and imports. The result is a cleaner and more maintainable codebase. The review did not identify any issues.
wangxiyuan
added
ready
Yikun
approved these changes
Sep 30, 2025
wangxiyuan
pushed a commit
that referenced
this pull request
Oct 9, 2025
### What this PR does / why we need it? Since #3284 merged, should discard some extra code that was previously done for version compatibility ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? - vLLM version: v0.11.0 Signed-off-by: wangli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop v0.10.2 support, we support vLLM 0.11.0rc3 now.