-
Notifications
You must be signed in to change notification settings - Fork 600
Unset NZ in BF16/FP16 #4415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
henryxuxu0716
wants to merge
6
commits into
vllm-project:v0.11.0-dev
Choose a base branch
from
henryxuxu0716:v0.11.0-dev
base: v0.11.0-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Unset NZ in BF16/FP16 #4415
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0ca6bda
modify nz in bf16
791020e
Merge branch 'vllm-project:v0.11.0-dev' into v0.11.0-dev
henryxuxu0716 7d1db34
[Doc][v11.0-dev][cherry-pick]Add single node PD disaggregation instru…
mazhixin000 a462fcd
modify nz in bf16
7027439
modify nz in bf16
adfce69
modify nz in bf16
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -71,13 +71,15 @@ def is_310p(): | |||||||||
| return _IS_310P | ||||||||||
|
|
||||||||||
|
|
||||||||||
| def is_enable_nz(vllm_config: Optional[VllmConfig] = None) -> bool: | ||||||||||
| def is_enable_nz(dtype: Optional[torch.dtype] = torch.int8, vllm_config: Optional[VllmConfig] = None) -> bool: | ||||||||||
| global _ENABLE_NZ | ||||||||||
| if _ENABLE_NZ is None: | ||||||||||
| if not vllm_config: | ||||||||||
| raise ValueError( | ||||||||||
| "vllm_config must be provided when _ENABLE_NZ is None") | ||||||||||
| _ENABLE_NZ = envs_ascend.VLLM_ASCEND_ENABLE_NZ and vllm_config.model_config.hf_config.model_type != "qwen3_next" | ||||||||||
| if dtype in [torch.float16, torch.bfloat16]: | ||||||||||
| _ENABLE_NZ = 0 | ||||||||||
|
Comment on lines
+81
to
+82
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
为了避免这种副作用,建议不要修改全局变量,而是根据
Suggested change
|
||||||||||
| return _ENABLE_NZ | ||||||||||
|
|
||||||||||
|
|
||||||||||
|
|
||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
此处调用
is_enable_nz时使用了layer.w13_weight.data.type,这似乎是一个错误。torch.Tensor.type是一个返回类型字符串(例如'torch.npu.FloatTensor')的方法,而不是torch.dtype对象。is_enable_nz函数期望接收一个torch.dtype对象。你应该使用
.dtype属性来获取张量的数据类型。