-
Notifications
You must be signed in to change notification settings - Fork 600
Change comment location #4432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Change comment location #4432
Conversation
Signed-off-by: herizhen <[email protected]>
Signed-off-by: herizhen <[email protected]>
Signed-off-by: herizhen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to improve the documentation for handling connection issues when downloading models. While the intention is good, the added text has some grammatical issues and could be clearer. I've provided suggestions to improve the readability and also to fix a minor issue with a trailing space in a command.
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
Signed-off-by: herizhen <[email protected]>
Signed-off-by: herizhen <[email protected]>
Signed-off-by: herizhen <[email protected]>
Signed-off-by: herizhen <[email protected]>
Signed-off-by: herizhen <[email protected]>
What this PR does / why we need it?
When running 'python example .py',connection issues often occur.The solution is to comment out the first line the code.
Does this PR introduce any user-facing change?
no
How was this patch tested?
ut