-
Notifications
You must be signed in to change notification settings - Fork 975
[Refactor] Use forward mapping instead of reverse mapping in AscendModelSlimConfig #7596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Feng-xiaosuo
wants to merge
17
commits into
vllm-project:main
Choose a base branch
from
Feng-xiaosuo:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+11
−128
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
7da8957
refactor(modelslim_config.py): Optimize the prefix mapping logic of …
465da16
fix pre-commit error of quantization refractor
e4a10df
Merge branch 'main' into main
Feng-xiaosuo 7522d5d
Merge branch 'main' into main
Feng-xiaosuo 5505b1f
Merge branch 'main' into main
Feng-xiaosuo a7f9d3a
Merge branch 'vllm-project:main' into main
Feng-xiaosuo 609c0e1
Merge branch 'main' into main
Feng-xiaosuo 5da4e27
Merge branch 'main' into main
Feng-xiaosuo 3185724
Merge branch 'main' into main
Feng-xiaosuo 44f6a17
Update vllm_ascend/quantization/modelslim_config.py
Feng-xiaosuo 163c611
Merge branch 'main' into main
Feng-xiaosuo 570e1b9
Merge branch 'main' into main
Feng-xiaosuo 1853c86
Merge branch 'main' into main
Feng-xiaosuo c43ea2c
Merge branch 'main' into main
Feng-xiaosuo 9c7705c
Merge branch 'main' into main
Feng-xiaosuo bebf158
Merge branch 'main' into main
Feng-xiaosuo 4ea4381
Merge branch 'vllm-project:main' into main
Feng-xiaosuo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current logic for checking if the mapper has been applied is not fully robust. If
apply_vllm_mapperis called a second time with a different mapper instance, the conditionself.hf_to_vllm_mapper is hf_to_vllm_mapperwill be false. The code would then proceed to apply the new mapping on thequant_descriptionkeys which have already been transformed, leading to incorrect behavior.Since
apply_dictmodifies thequant_descriptionstate, re-applying a mapping is not safe. To prevent this potential bug, you should add a more robust check to error out if a different mapper is provided after the first application.