feat: Add sccache to speed up Docker image building#7618
feat: Add sccache to speed up Docker image building#7618tfhddd wants to merge 1 commit intovllm-project:mainfrom
Conversation
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Docker image building process by introducing sccache, a compiler caching tool. The changes modify several Dockerfiles and associated build configurations to enable and utilize sccache, aiming to reduce build times and improve overall efficiency, especially within a GitHub Actions environment. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request integrates sccache into the Docker image build process across various Dockerfiles to enhance build caching and reduce build times. It introduces new build arguments and modifies build scripts to utilize sccache. The review highlights a critical issue where the specified sccache version v0.14.0 is incorrect and will cause build failures, suggesting v0.8.0 as a valid alternative. Additionally, the sccache installation logic is duplicated across multiple Dockerfiles, which should be refactored into a shared script for better maintainability.
7e93879 to
7081208
Compare
feat: Add sccache to speed up compilation feat: Add sccache to speed up compilation feat: Add sccache to speed up compilation feat: Add sccache to speed up compilation feat: Add sccache to speed up compilation Signed-off-by: tfhddd <2272751277@qq.com>
7081208 to
8e67fee
Compare
What this PR does / why we need it?
The current Docker build time is too long. By adding sccache, the compilation speed of mooncake and vllm-ascend can be improved.
Does this PR introduce any user-facing change?
Why use GitHub's GHA for caching:
Docker image builds use GitHub servers, and using GitHub's GHA can avoid network latency.
How was this patch tested?
Currently, the overall build time is 2 hours and 38 minutes.

After optimization, the overall build time is 1 hour and 14 minutes.
