[CI] Support branch-based nightly testing with dynamic vLLM version#7627
[CI] Support branch-based nightly testing with dynamic vLLM version#7627zhangxinyuehfad wants to merge 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: hfadzxy <starmoon_zhang@163.com>
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the Continuous Integration (CI) workflows to support branch-based nightly testing with dynamic vLLM versions. Previously, CI workflows hardcoded vLLM versions and image tags, limiting flexibility. The changes introduce a unified approach to derive versions from branch names, ensuring that nightly tests and image builds correctly correspond to the specific vLLM version being tested across different branches. This significantly improves the maintainability and accuracy of the nightly CI system. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates VLLM Docker image references in multi-node test documentation and Kubernetes deployment templates. It replaces hardcoded 'nightly-a2' or 'nightly-a3' image tags with dynamic tags that incorporate a 'vllm_version' variable. This change enables more flexible and configurable image versioning for CI/CD pipelines and local testing environments. No user-facing changes are introduced, and the modifications are implicitly tested by existing CI/CD pipelines. There is no feedback to provide as no review comments were submitted.
What this PR does / why we need it?
Nightly CI workflows previously hardcoded the vLLM version (
v0.18.0) and image tag (nightly-a2/nightly-a3) in multiple places. This PR introduces a unified mechanism to derive the version from the branch name, enabling proper multi-branch nightly testing.Key changes:
_parse_trigger.yaml: Addbranchinput; auto-derivevllm_versionfrom branch name (releases-v0.13.0→v0.13.0); detect PR target branch to select the matching nightly image;getRef()prefersinputs.branchfor dispatch triggers_nightly_image_build.yaml: Image tag now includes version (e.g.,nightly-v0.18.0-a2)_e2e_nightly_single_node.yaml: Addvllm_ascend_refinput; on dispatch with a ref, checkout and reinstall vllm-ascend from the branch; consolidate PR setup steps (7 → 4 steps); renameis_run→should_runschedule_nightly_test_a2.yaml/schedule_nightly_test_a3.yaml: Passbranchinput; derivevllm_versiondynamically viaparse-trigger; propagatevllm_ascend_refto single-node testsnightly_image_build.yaml: Addvllm_versioninput to fix missing required parameterlws*.yaml.jinja2: Image default constructed fromvllm_versionvariablemulti_node_test.md: Use|ci_vllm_version|substitution instead of hardcoded version这个翻译
Does this PR introduce any user-facing change?
How was this patch tested?