[CI] Add PR-comment-only accuracy test group for A2 nightly workflow#7629
[CI] Add PR-comment-only accuracy test group for A2 nightly workflow#7629zhangxinyuehfad wants to merge 5 commits intovllm-project:mainfrom
Conversation
Signed-off-by: hfadzxy <starmoon_zhang@163.com>
Signed-off-by: hfadzxy <starmoon_zhang@163.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the CI/CD pipeline by introducing a new configuration file that defines accuracy test groups for the A2 platform. It specifically adds a 'pr_only' test group, allowing for targeted accuracy testing of models like 'gemma-3-4b-it' during pull request reviews. This change aims to improve the efficiency and relevance of testing by running specific accuracy checks only when needed for PRs, rather than solely in nightly builds. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
|
/nightly accuracy-group-1 Qwen3-VL-8B-Instruct-W8A8 |
There was a problem hiding this comment.
Code Review
What this PR does / why we need it?
This pull request introduces a new configuration file, accuracy_groups_a2.json, within tests/e2e/models/configs/. This file defines several accuracy test groups, specifying various models (such as Qwen3, ERNIE, Llama, and Gemma) to be tested on different linux-aarch64-a2b3 OS configurations. These groups are categorized for both nightly and pr_only test runs, thereby expanding the e2e testing coverage for model accuracy on A2B3 hardware.
Does this PR introduce any user-facing change?
No, this PR only adds internal test configuration.
How was this patch tested?
This patch adds a new configuration file for e2e tests. The tests themselves would utilize this configuration, and their successful execution would validate this change. No specific new tests were added for this configuration file itself.
There is no feedback to provide on the code changes.
Signed-off-by: hfadzxy <starmoon_zhang@163.com>
Signed-off-by: hfadzxy <starmoon_zhang@163.com>
Signed-off-by: hfadzxy <starmoon_zhang@163.com>
What this PR does / why we need it?
Move the hardcoded accuracy test group configuration out of the A2 nightly
workflow and into a versioned JSON file under tests/e2e/models/configs/.
This makes adding, removing, or rebalancing accuracy groups a config-file
change rather than a workflow edit.
Defines two sections:
Changes:
Does this PR introduce any user-facing change?
How was this patch tested?