Conversation
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a doctest issue by standardizing the versions of Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Signed-off-by: wangli <wangli858794774@gmail.com>
There was a problem hiding this comment.
Code Review
This pull request updates the pinned versions of torchvision and torchaudio to 0.24.0 and 2.9.0 respectively in requirements.txt and ensures they are explicitly installed in the e2e test script. It also removes a specific pip mirror configuration from the test setup. A critical issue was identified in the e2e test script where the global.extra-index-url was inadvertently truncated, which is likely to cause installation failures for vllm-ascend and its dependencies.
What this PR does / why we need it?
This patch fix the doc test failure:
Does this PR introduce any user-facing change?
How was this patch tested?