Skip to content

[Misc] Fix doctest#7648

Open
Potabk wants to merge 4 commits intovllm-project:mainfrom
Potabk:fix_doc2
Open

[Misc] Fix doctest#7648
Potabk wants to merge 4 commits intovllm-project:mainfrom
Potabk:fix_doc2

Conversation

@Potabk
Copy link
Collaborator

@Potabk Potabk commented Mar 25, 2026

What this PR does / why we need it?

This patch fix the doc test failure:

  1. Force the versions of torchaudio and torchvision to match the version of torch_npu(refer https://github.com/pytorch/pytorch/wiki/PyTorch-Versions)
  2. Some convenience fixes to prevent network fluctuations from causing test failures(eg: offline mode for ms)

Does this PR introduce any user-facing change?

How was this patch tested?

Potabk added 2 commits March 25, 2026 22:23
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
@github-actions
Copy link
Contributor

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a doctest issue by standardizing the versions of torchvision and torchaudio across the project's dependency list and its end-to-end testing environment. The changes ensure that the test setup consistently uses the intended versions, thereby improving the reliability and reproducibility of the tests.

Highlights

  • Dependency Version Pinning: Pinned torchvision and torchaudio to specific versions (0.24.0 and 2.9.0 respectively) in requirements.txt to ensure consistent dependency resolution.
  • E2E Test Script Update: Modified the 002-pip-binary-installation-test.sh script to explicitly install torchvision and torchaudio with their pinned versions, and removed an unnecessary global pip mirror configuration.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Signed-off-by: wangli <wangli858794774@gmail.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pinned versions of torchvision and torchaudio to 0.24.0 and 2.9.0 respectively in requirements.txt and ensures they are explicitly installed in the e2e test script. It also removes a specific pip mirror configuration from the test setup. A critical issue was identified in the e2e test script where the global.extra-index-url was inadvertently truncated, which is likely to cause installation failures for vllm-ascend and its dependencies.

Signed-off-by: wangli <wangli858794774@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant