[BugFix] Fix flash comm v1 bugs of Qwen3.5 series on A2 platform#7683
[BugFix] Fix flash comm v1 bugs of Qwen3.5 series on A2 platform#7683wangbj127 wants to merge 1 commit intovllm-project:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses specific bugs affecting the Qwen3.5 series models when running on the A2 platform. The changes primarily refine the conditional logic for tensor communication and reduction operations, ensuring that multimodal and vision-language models correctly interact with Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refines the conditions for applying tensor parallel communication and padding/reduction operations within the vllm_ascend framework. It modifies vllm_ascend/ops/register_custom_ops.py to include is_ep_comm in the bypass condition for draft and VL models when flash_comm_v1 is disabled. Additionally, in vllm_ascend/spec_decode/eagle_proposer.py, it adjusts the maybe_pad_and_reduce function to prevent multimodal models from undergoing padding and reduction when flash_comm_v1 is enabled, by removing an early return and adding a not self.is_multimodal_model check to the reduction logic. These changes aim to ensure correct behavior and potentially optimize performance for multimodal and other specific model configurations under different communication settings. There are no review comments to address.
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
f7303bd to
5839062
Compare
Signed-off-by: wangbj127 <wangbj1207@126.com>
What this PR does / why we need it?
Does this PR introduce any user-facing change?
How was this patch tested?