Skip to content

Issue auto set label optimize: remove match label from issue body#7696

Merged
MengqingCao merged 4 commits intovllm-project:mainfrom
leo-pony:label_opt
Mar 26, 2026
Merged

Issue auto set label optimize: remove match label from issue body#7696
MengqingCao merged 4 commits intovllm-project:mainfrom
leo-pony:label_opt

Conversation

@leo-pony
Copy link
Copy Markdown
Collaborator

@leo-pony leo-pony commented Mar 26, 2026

What this PR does / why we need it?

  1. Issue auto set label optimize: remove match label from issue body
  2. optimize auto-label match reguler for model:glm, wan, qwen-next,emu,eplb,deepseek
  3. optimize label name structure: replace '_' to '-'.

Does this PR introduce any user-facing change?

How was this patch tested?

Signed-off-by: leo-pony <nengjunma@outlook.com>
Signed-off-by: leo-pony <nengjunma@outlook.com>
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request optimizes the automatic issue labeling system by refining the regular expressions used to identify keywords in issue bodies. The changes aim to improve the precision and coverage of label assignments, ensuring that issues are categorized more accurately based on their content, and also standardizes some label names for consistency.

Highlights

  • Configuration File Renames: Renamed the label keys advanced_features to advanced-features and multimodal_understanding to multimodal-understanding in the issue labeler configuration.
  • Improved Regular Expression Matching: Updated numerous regular expressions for various labels (e.g., advanced-features, eplb, llm-model, glm5, qwen3-next, glm-4, multi-modality-generate, wan, multimodal-unified-autoregress) to enhance accuracy, primarily by adding word boundaries (\b) and refining model name patterns.
  • Expanded Model Recognition: The llm-model and multi-modality-generate labels now include more specific patterns for models like 'kimi k2.5', 'glm-5', 'glm 5', and refined 'qwen3-next' and 'glm 4.x' recognition.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/bot_issue_manage.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

What this PR does / why we need it?

This PR updates the .github/issue-labeler.yml file to refine the regular expressions used for automatically labeling GitHub issues. It introduces new patterns for various LLM models and features, including eplb, kimi k2.5, glm5, qwen3-next, wan, and emu. Additionally, it standardizes some label names by replacing underscores with hyphens (e.g., advanced_features to advanced-features).

A critical issue was identified in the updated regular expression for glm-4 models. The current pattern \.[0-9] is too restrictive, only matching single-digit minor versions (e.g., glm-4.5 but not glm-4.10). Furthermore, the negative lookahead (?![a-zA-Z0-9-]) is overly restrictive, preventing correct matching of model names with common suffixes like glm-4.5-instruct. These issues could lead to incorrect or missed labeling of relevant issues.

Does this PR introduce any user-facing change?

No, this PR only modifies internal GitHub issue labeling configuration.

How was this patch tested?

The changes are to a GitHub configuration file and do not involve code that requires unit tests. The regex patterns should be manually verified for correctness.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Signed-off-by: leo-pony <nengjunma@outlook.com>
Signed-off-by: leo-pony <nengjunma@outlook.com>
@MengqingCao MengqingCao merged commit 2b735a2 into vllm-project:main Mar 26, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants