Issue auto set label optimize: remove match label from issue body#7696
Issue auto set label optimize: remove match label from issue body#7696MengqingCao merged 4 commits intovllm-project:mainfrom
Conversation
Signed-off-by: leo-pony <nengjunma@outlook.com>
Signed-off-by: leo-pony <nengjunma@outlook.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request optimizes the automatic issue labeling system by refining the regular expressions used to identify keywords in issue bodies. The changes aim to improve the precision and coverage of label assignments, ensuring that issues are categorized more accurately based on their content, and also standardizes some label names for consistency. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
What this PR does / why we need it?
This PR updates the .github/issue-labeler.yml file to refine the regular expressions used for automatically labeling GitHub issues. It introduces new patterns for various LLM models and features, including eplb, kimi k2.5, glm5, qwen3-next, wan, and emu. Additionally, it standardizes some label names by replacing underscores with hyphens (e.g., advanced_features to advanced-features).
A critical issue was identified in the updated regular expression for glm-4 models. The current pattern \.[0-9] is too restrictive, only matching single-digit minor versions (e.g., glm-4.5 but not glm-4.10). Furthermore, the negative lookahead (?![a-zA-Z0-9-]) is overly restrictive, preventing correct matching of model names with common suffixes like glm-4.5-instruct. These issues could lead to incorrect or missed labeling of relevant issues.
Does this PR introduce any user-facing change?
No, this PR only modifies internal GitHub issue labeling configuration.
How was this patch tested?
The changes are to a GitHub configuration file and do not involve code that requires unit tests. The regex patterns should be manually verified for correctness.
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
Signed-off-by: leo-pony <nengjunma@outlook.com>
Signed-off-by: leo-pony <nengjunma@outlook.com>
What this PR does / why we need it?
Does this PR introduce any user-facing change?
How was this patch tested?