Fixes for #33559 and #34103#1019
Open
iboiko-habana wants to merge 2 commits intovllm-project:releases/v0.16.0from
Open
Fixes for #33559 and #34103#1019iboiko-habana wants to merge 2 commits intovllm-project:releases/v0.16.0from
iboiko-habana wants to merge 2 commits intovllm-project:releases/v0.16.0from
Conversation
Collaborator
iboiko-habana
commented
Feb 24, 2026
iboiko-habana
commented
- Port of Qwen3_vl WarmUp Fix #994 - #33559
- change: "from vllm.multimodal.budget import MultiModalBudget" to "from vllm.multimodal.encoder_budget import MultiModalBudget" - #34103
Signed-off-by: Iryna Boiko <iboiko@habana.ai>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ports a multimodal warmup fix (from vllm-gaudi PR #994) and updates the MultiModalBudget import path to match upstream vLLM changes, addressing issues #33559 and #34103.
Changes:
- Fix
_get_mm_dummy_batchto pass(modality, item)pairs intogroup_mm_kwargs_by_modality, aligning with how other call sites batch multimodal inputs. - Update
MultiModalBudgetimport tovllm.multimodal.encoder_budgetto reflect the new upstream module location.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.