Fix tensor device mismatch in deepseek#1029
Open
kamil-kaczor wants to merge 4 commits intoreleases/v0.15.1from
Open
Fix tensor device mismatch in deepseek#1029kamil-kaczor wants to merge 4 commits intoreleases/v0.15.1from
kamil-kaczor wants to merge 4 commits intoreleases/v0.15.1from
Conversation
Signed-off-by: Kamil Kaczor <kamil.kaczor@intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a tensor device mismatch issue in the DeepSeek rotary embedding implementation when using INC (Intel Neural Compressor) quantization. The issue occurs because upstream code hardcodes device placement to HPU, but during INC quantization workflows, weights are loaded to CPU first (via load_config.device="cpu"), causing runtime errors when utility functions create tensors on different devices.
Changes:
- Added imports for
yarn_find_correction_rangeandyarn_linear_ramp_maskutility functions from vLLM's rotary embedding common module - Override
_compute_inv_freqmethod to remove explicit device specification, allowing tensors to follow thetorch.set_default_devicecontext - Override
_compute_cos_sin_cachemethod to maintain device consistency with the compute_inv_freq implementation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Kamil Kaczor <kamil.kaczor@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.