Remove all lazy execution mode from the codebase -> eager is the new default#996
Remove all lazy execution mode from the codebase -> eager is the new default#996afierka-intel wants to merge 10 commits intomainfrom
Conversation
Signed-off-by: Artur Fierka <artur.fierka@intel.com>
🚧 CI BlockedThe main CI workflow was not started for the following reason:
|
There was a problem hiding this comment.
Pull request overview
This pull request removes lazy execution mode from the codebase, making eager execution the new default for the vLLM-HPU (Habana Processing Unit) plugin. The change eliminates all references to PT_HPU_LAZY_MODE=1 (lazy mode) throughout the test scripts, CI/CD configurations, examples, and documentation, effectively standardizing on eager mode (PT_HPU_LAZY_MODE=0 or unset).
Changes:
- Removed
PT_HPU_LAZY_MODE=1environment variable settings from all test scripts, examples, and CI/CD workflows - Updated calibration scripts to remove conditional logic that differentiated between lazy and eager modes
- Modified test expectations to reflect eager mode as the default
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/upstream_tests/ci_tests.sh | Removed PT_HPU_LAZY_MODE=1 from basic model test commands |
| tests/unit_tests/run_accuracy_test.sh | Removed export of PT_HPU_LAZY_MODE=1 |
| tests/full_tests/ci_perf_tests.sh | Removed PT_HPU_LAZY_MODE=1 from performance benchmark tests |
| tests/full_tests/ci_e2e_discoverable_tests.sh | Removed PT_HPU_LAZY_MODE=1 from 30+ test functions covering various model configurations |
| examples/nixl/run_hpu_disagg_accuracy_test.sh | Removed commented-out PT_HPU_LAZY_MODE export |
| examples/nixl/run_benchmark_test.sh | Removed PT_HPU_LAZY_MODE=1 export from benchmark configuration |
| examples/nixl/run_benchmark_profile.sh | Removed PT_HPU_LAZY_MODE=1 export from profiling configuration |
| examples/nixl/run_accuracy_test.sh | Removed PT_HPU_LAZY_MODE=1 export from accuracy test setup |
| docs/configuration/warm-up/managing_warm-up.md | Removed PT_HPU_LAZY_MODE=1 from documentation example command |
| docs/configuration/calibration/calibration_one_node.md | Removed PT_HPU_LAZY_MODE=1 from calibration example for DeepSeek models |
| calibration/calibrate_model.sh | Simplified conditional logic to always use CONST scale_format for mixtral models (previously conditional on lazy mode) |
| .jenkins/test_config.yaml | Removed PT_HPU_LAZY_MODE=1 from Jenkins CI test configurations |
| .github/workflows/pre-merge.yaml | Removed PT_HPU_LAZY_MODE=1 from pre-merge GitHub Actions workflow |
| .github/workflows/hourly-ci.yaml | Removed PT_HPU_LAZY_MODE=1 from hourly CI GitHub Actions workflow |
| .github/workflows/create-release-branch.yaml | Removed PT_HPU_LAZY_MODE=1 from release branch creation workflow |
| .cd/tests/test_vllm_autocalc.py | Updated test to expect PT_HPU_LAZY_MODE=0 instead of =1 |
Comments suppressed due to low confidence (4)
tests/full_tests/ci_e2e_discoverable_tests.sh:105
- The comment "The lazy mode works on 1.24.0-272" is now obsolete since PT_HPU_LAZY_MODE=0 has been removed from the command on line 108. This comment should be updated or removed to reflect that eager mode is now the default and these tests run with eager mode.
# The lazy mode works on 1.24.0-272
.cd/tests/test_vllm_autocalc.py:41
- The test is being updated to use PT_HPU_LAZY_MODE=0 instead of PT_HPU_LAZY_MODE=1, which correctly aligns with making eager mode the default. However, this test file still references PT_HPU_LAZY_MODE in the varlist configuration (line 18) and in the test assertion. If lazy mode is being completely removed from the codebase, consider whether this test should be updated to test a different environment variable, or if the PT_HPU_LAZY_MODE variable should be removed from the test configuration entirely.
monkeypatch.setenv("PT_HPU_LAZY_MODE", "0")
vg = VarsGenerator(**minimal_config)
vg.overwrite_params()
assert vg.context["PT_HPU_LAZY_MODE"] == 0
tests/full_tests/ci_e2e_discoverable_tests.sh:89
- The comment "The lazy mode works on 1.24.0-272" is now obsolete since PT_HPU_LAZY_MODE=0 has been removed from the command on line 92. This comment should be updated or removed to reflect that eager mode is now the default and these tests run with eager mode.
# The lazy mode works on 1.24.0-272
tests/full_tests/ci_e2e_discoverable_tests.sh:97
- The comment "The lazy mode works on 1.24.0-272" is now obsolete since PT_HPU_LAZY_MODE=0 has been removed from the command on line 100. This comment should be updated or removed to reflect that eager mode is now the default and these tests run with eager mode.
# The lazy mode works on 1.24.0-272
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Artur Fierka <artur.fierka@intel.com>
🚧 CI BlockedThe main CI workflow was not started for the following reason:
|
Signed-off-by: Artur Fierka <artur.fierka@intel.com>
…tching envs Signed-off-by: Artur Fierka <artur.fierka@intel.com>
No description provided.