-
Notifications
You must be signed in to change notification settings - Fork 473
[Config Refactor][1/N] Model Pipeline Configuration System #1115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lishunyang12
wants to merge
6
commits into
vllm-project:main
Choose a base branch
from
lishunyang12:config_ref
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5d80782
[Config Refactor][1/N] Two-Tier Stage Configuration System
lishunyang12 5158381
address review: add get_stage(), fix per-stage internal key filtering
lishunyang12 3b3d610
address review: restructure config per wuhang/hsliu feedback
lishunyang12 65fd4ef
fix default_args.yaml to match wuhang's example format
lishunyang12 81e0218
address hsliuustc0106 review: fix stage_ prefix, sentinel, trust_remo…
lishunyang12 6c6c31c
remove unused OmegaConf import in omni.py
lishunyang12 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if these parameters are set individually now, it will apply to all stages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right — global CLI params like
--gpu-memory-utilizationapply to every stage by default. Per-stage overrides (--stage-N-*) take precedence when specified. Added a comment at the kwargs block to clarify this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, global args like --gpu-memory-utilization apply to all stages. Per-stage overrides (--stage-N-*) take precedence when specified — this will be wired up in [2/N].