[feature] : add cache-dit for stable-audio-open-1.0#1341
Open
akshatvishu wants to merge 7 commits intovllm-project:mainfrom
Open
[feature] : add cache-dit for stable-audio-open-1.0#1341akshatvishu wants to merge 7 commits intovllm-project:mainfrom
akshatvishu wants to merge 7 commits intovllm-project:mainfrom
Conversation
1 task
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf50517d5d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Collaborator
|
fix DCO please |
Signed-off-by: akshatvishu <akshatnayak197@gmail.com>
Signed-off-by: akshatvishu <akshatnayak197@gmail.com>
…g warmup" This reverts commit e4c5a1f. Signed-off-by: akshatvishu <akshatnayak197@gmail.com>
Signed-off-by: akshatvishu <akshatnayak197@gmail.com>
cf50517 to
4569fd7
Compare
Author
|
@hsliuustc0106 Sorry! I've updated it ! |
Signed-off-by: akshatvishu <akshatnayak197@gmail.com>
…p/cache-dit Signed-off-by: akshatvishu <akshatnayak197@gmail.com>
…tion Signed-off-by: akshatvishu <akshatnayak197@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1217
Purpose
Add cache-dit support for stable audio open 1.0
Test Plan
full comprehensive testing can be found in this kaggle_notebook
Test Result
Device:
cudaGPU:
NVIDIA Tesla T4Prompt :
The sound of a hammer hitting a wooden surfacenum_inference_steps=
100guidance_scale=
7.0,max_audio_length =
10 secondsBaseline:
Config1:
Config2:
Config3:
Files are in
.mp3format as github doesn't support.wavin comments.Note :
Stable Audio Open 1.0 exhibits a high natural step-to-step drift (median residual ≈0.34) as seen in
cache-dit.summary()when running the same config as vllm-omni in hf diffuser+cache-dit setup. To achieve significant speedups on T4 hardware, it is necessary to use aresidual_diff_thresholdnear or above this drift value as using conservativeresidual_diff_thresholdlike0.12resulted in1.00xspeedup (or even slowdowns) because the cache missed on nearly every step, leaving only the management overhead without any compute savings.The vllm-omni orchestrator performs a 1-step dummy warmup run during server initialization, If a user provides an SCM (Step Computation Masking) policy, the engine crashes with the following error:
Thus, I am wondering if we should a guard condition like below or it's an acceptable behavior.
_repeated_blocks = ["StableAudioDiTBlock"]toStableAudioDiTModelto enable regional compilation and backend patching.Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)